player.xml: Rename fullscreen buttons & separate enter/exit#12612
Merged
Stypox merged 2 commits intoTeamNewPipe:refactorfrom Sep 7, 2025
Merged
player.xml: Rename fullscreen buttons & separate enter/exit#12612Stypox merged 2 commits intoTeamNewPipe:refactorfrom
Stypox merged 2 commits intoTeamNewPipe:refactorfrom
Conversation
Their names must have come from a very old version of the app, they both toggle the fullscreen mode and rotate the screen depending on circumstances. So `fullscreenButton` -> `fullscreenToggleButtonSecondaryMenu` because it is only visible in the secondary video menu on some configurations. and `screenRotationButton` -> `fullscreenToggleButton` because it is the main fullscreen button next to the video progress bar.
Most usages of `toggleFullscreen` are clear about whether they want to enter or exit fullscreen, so let’s split the setup into two functions for easier debugging. The two remaining uses of `toggleFullscreen` *should* really toggle, but I’m not 100% sure. Also rename `onScreenRotationButtonClicked` to `onFullscreenToggleButtonClicked`, since we renamed the button id earlier.
Profpatsch
changed the title
github-actions
Bot
added
size/medium
AudricV
added
player
Stypox
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Their names must have come from a very old version of the app, they both toggle the fullscreen mode and rotate the screen depending on circumstances.
So
fullscreenButton->fullscreenToggleButtonSecondaryMenubecause it is only visible in the secondary video menu on some configurations andscreenRotationButton->fullscreenToggleButtonbecause it is the main fullscreen button next to the video progress bar.Due diligence