Use an ImageVector app icon in About screen#12609
Merged
Stypox merged 2 commits intoTeamNewPipe:refactorfrom Sep 6, 2025
Merged
Use an ImageVector app icon in About screen#12609Stypox merged 2 commits intoTeamNewPipe:refactorfrom
Stypox merged 2 commits intoTeamNewPipe:refactorfrom
Conversation
Also optimize them with svgo
5 tasks
Stypox
changed the title
Isira-Seneviratne
requested changes
Sep 6, 2025
| @Composable | ||
| private fun IconPreview() { | ||
| org.schabi.newpipe.ui.theme.AppTheme { | ||
| Column( |
Member
There was a problem hiding this comment.
This column is unnecessary, as the Image is the only child.
Member
Author
There was a problem hiding this comment.
That's just autogenerated code, but yeah I removed it, thanks for noticing
Member
|
LGTM |
Stypox
force-pushed
the
image-vector-app-icon
branch
from
ea4fecb to
b362014
Compare
github-actions
Bot
added
size/medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Supersedes #12426 by creating a Kotlin
ImageVectorfor the app icon instead of relying on an external library just to render a drawable. This required remaking the app icon SVGs so that they use only as little lines as needed instead of a bunch of bezier curves (I mean, curves would have also worked, but it was a useless mess). Then the new squircle SVG was converted toImageVectorwith https://github.com/rafaeltonholo/svg-to-compose/ based on assets/newpipe_squircle.svg.Before/After Screenshots/Screen Record
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence