Issue#12490#12607
Closed
cp89cyber wants to merge 2 commits intoTeamNewPipe:devfrom
cp89cyber:issue#12490
Closed
Conversation
…nding-podcasts Fix kiosk extraction when channel name missing
Profpatsch
reviewed
Sep 9, 2025
| @@ -204,6 +217,33 @@ public static Single<InfoItemsPage<StreamInfoItem>> getMoreKioskItems(final int | |||
| KioskInfo.getMoreItems(NewPipe.getService(serviceId), url, nextPage)); | |||
| } | |||
Contributor
There was a problem hiding this comment.
Shouldn’t this have fallback code as well? Might fail when scrolling down otherwise
Comment on lines
+233
to
+237
| final Constructor<KioskInfo> constructor = KioskInfo.class | ||
| .getDeclaredConstructor(int.class, ListLinkHandler.class, String.class); | ||
| constructor.setAccessible(true); | ||
| final KioskInfo info = constructor.newInstance(extractor.getServiceId(), | ||
| extractor.getLinkHandler(), name); |
Contributor
There was a problem hiding this comment.
We control the library, I’d avoid the reflection
Member
|
I don't think this is the way to solve it: it seems like the channel is not available at all, and what should rather be done is to make NewPipeExtractor notice when a channel is not available. But we could indeed make the extraction of the name non mandatory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a fallback path for kiosk loading when the extractor cannot provide a channel name, allowing the kiosk loader to return a valid KioskInfo instead of failing
Implemented getKioskInfoFallback, which reconstructs the kiosk info using the kiosk’s ID and populates items and pagination details from the extractor
Testing
Fixes #12490