Skip to content

Clean up EmptyStateComposable code#12604

Merged
Stypox merged 1 commit intoTeamNewPipe:refactorfrom
Isira-Seneviratne:Refactor-EmptyState
Sep 6, 2025
Merged

Clean up EmptyStateComposable code#12604
Stypox merged 1 commit intoTeamNewPipe:refactorfrom
Isira-Seneviratne:Refactor-EmptyState

Conversation

@Isira-Seneviratne
Copy link
Copy Markdown
Member

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Avoid allocating lambdas in the EmptyStateSpec class to reduce the number of classes present, and convert it to an enum.
  • Refactor EmptyStateComposable to use just one composable function.

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label Sep 5, 2025
@Isira-Seneviratne Isira-Seneviratne added code quality Improvements to the codebase to improve the code quality rewrite Issues and PRs related to rewrite and removed size/medium PRs with less than 250 changed lines labels Sep 5, 2025
@github-project-automation github-project-automation Bot moved this to In Progress in Rewrite Sep 5, 2025
@Isira-Seneviratne Isira-Seneviratne added the size/medium PRs with less than 250 changed lines label Sep 5, 2025
Copy link
Copy Markdown
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stypox Stypox merged commit b2d89a4 into TeamNewPipe:refactor Sep 6, 2025
5 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Rewrite Sep 6, 2025
@Isira-Seneviratne Isira-Seneviratne deleted the Refactor-EmptyState branch September 7, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Improvements to the codebase to improve the code quality rewrite Issues and PRs related to rewrite size/medium PRs with less than 250 changed lines

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants