Better error panels and centralized error handling in ErrorInfo#12603
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Sep 5, 2025
Merged
Better error panels and centralized error handling in ErrorInfo#12603Stypox merged 1 commit intoTeamNewPipe:devfrom
Stypox merged 1 commit intoTeamNewPipe:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This is a followup of #12578 that will also be used as a base for #12404. With these changes, every time an error panel is shown, it will be possible to open it in browser the corresponding resource (if applicable).
Also, the ErrorInfo class is now fully serializable, as it does not store the throwable anymore, but it rather holds all information about the throwable that might be needed (e.g. whether there is a ReCaptcha URL, whether the error can be retried, whether the error is reportable).
In
RouterActivity, when a ReCaptcha happens, the recaptcha URL is now passed to the recaptcha activity as expected. This was likely a bug before.This is for example the trending tab when network is off, you can now open in browser the trending URL:
In
SearchFragment, I had to build the openInBrowserUrl manually based on the search query, e.g. the following image redirects to https://www.youtube.com/results?search_query=test&sp=8AEB .APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
app(3).zip
Due diligence