Skip to content

build: keep proto-generated files#12469

Closed
FineFindus wants to merge 1 commit intoTeamNewPipe:devfrom
FineFindus:fix/missing-proguard-proto-rule
Closed

build: keep proto-generated files#12469
FineFindus wants to merge 1 commit intoTeamNewPipe:devfrom
FineFindus:fix/missing-proguard-proto-rule

Conversation

@FineFindus
Copy link
Copy Markdown
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes, an issue, where the proto-generated files where removed by proguard, leading to an error.

Ref: TeamNewPipe/NewPipeExtractor#1104

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Fixes, an issue, where the proto-generated files where removed by
proguard, leading to an error.

Ref: TeamNewPipe/NewPipeExtractor#1104
@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Jul 26, 2025
@ShareASmile ShareASmile added the bug Issue is related to a bug label Jul 26, 2025
@litetex
Copy link
Copy Markdown
Member

litetex commented Jul 26, 2025

Fixes, an issue, where the proto-generated files where removed by proguard, leading to an error.

Could you please explain what the error is because I can't find it...

@FineFindus
Copy link
Copy Markdown
Contributor Author

Sure, the error is that Field browseId_ for org.schabi.newpipe.extractor.services.youtube.protos.playlist.PlaylistProtobufContinuation$ContinuationParams not found. Known fields are [public static final org.schabi.newpipe.extractor.services.youtube.protos.playlist.PlaylistProtobufContinuation$ContinuationParams org.schabi.newpipe.extractor.services.youtube.protos.playlist.PlaylistProtobufContinuation$ContinuationParams.DEFAULT_INSTANCE, public static volatile com.google.protobuf.GeneratedMessageLite$DefaultInstanceBasedParser org.schabi.newpipe.extractor.services.youtube.protos.playlist.PlaylistProtobufContinuation$ContinuationParams.PARSER].
It is printed right at startup. Presumably there will also be a crash when invoking the field. Please note that this should only appear in the release mode (with debugging turned off), as only then proguard is enabled.

@litetex
Copy link
Copy Markdown
Member

litetex commented Jul 26, 2025

@FineFindus

I currently have the latest nightly installed and I don't get such an error when the app starts (also not in the logs).

Could you provide more details?

@FineFindus
Copy link
Copy Markdown
Contributor Author

Hmm, I can't replicate it either anymore. Maybe I messed something up when building.

@FineFindus FineFindus closed this Jul 26, 2025
@ShareASmile ShareASmile removed the bug Issue is related to a bug label Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants