Use correct fix for nextPage being null while creating error report#12455
Merged
Stypox merged 2 commits intoTeamNewPipe:release-0.28.0from Jul 28, 2025
Merged
Use correct fix for nextPage being null while creating error report#12455Stypox merged 2 commits intoTeamNewPipe:release-0.28.0from
Stypox merged 2 commits intoTeamNewPipe:release-0.28.0from
Conversation
…n SearchFragment.handleNextItems()
5 tasks
Contributor
|
@TobiGr |
Stypox
approved these changes
Jul 28, 2025
Member
Stypox
left a comment
There was a problem hiding this comment.
We should still report the error if nextPage == null, I pushed a commit to do that. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
#12408 does not fix the underlying issue but tries to handle the symptoms.
nextPagecannot benullwhenhandleNextItems()is called, because at that point there is a page that was fetched.#12408 made it so that is unlikely that error reports are generated. When there was an ExtractionException it is likely that there is no nextPage. The issue is that nextPage is reassigned before generating the error report.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence