Refactor Settings Compose Setup#12385
Closed
HatakeKakashri wants to merge 2 commits intoTeamNewPipe:refactorfrom
Closed
Refactor Settings Compose Setup#12385HatakeKakashri wants to merge 2 commits intoTeamNewPipe:refactorfrom
HatakeKakashri wants to merge 2 commits intoTeamNewPipe:refactorfrom
Conversation
ShareASmile
added
code quality
HatakeKakashri
force-pushed
the
refine_settings_compose_setup
branch
4 times, most recently
from
f6f594e to
d4751ee
Compare
ShareASmile
added
the
ready for review
Isira-Seneviratne
requested changes
Aug 19, 2025
HatakeKakashri
force-pushed
the
refine_settings_compose_setup
branch
from
d4751ee to
47ddaed
Compare
Isira-Seneviratne
requested changes
Aug 22, 2025
HatakeKakashri
force-pushed
the
refine_settings_compose_setup
branch
from
47ddaed to
39a89d4
Compare
3 tasks
Member
|
It would be nice to switch to navigation3 to avoid more migration work whenever that hits stable. I will do that afterwards. |
Contributor
Author
That would be nice. I can take a look at Navigation 3. Quick question: are we looking for a specific feature in Navigation 3, or are we considering it mainly because it is newer and designed for Jetpack Compose? I’m a bit skeptical as the official documentation mentions that the library is still in alpha. |
HatakeKakashri
force-pushed
the
refine_settings_compose_setup
branch
from
39a89d4 to
d06244f
Compare
5 tasks
This PR refines the Settings screen setup using Jetpack Compose: * **Navigation Routing**: Updated navigation logic to use **Serialized Routes**, as recommended in the [official Compose navigation documentation](https://developer.android.com/develop/ui/compose/navigation). * **Screen Title Management**: Migrated screen title handling to a Compose-native approach instead of using `addOnDestinationChangedListener`. * **Toolbar Enhancements**: * Refined the toolbar layout and styling to improve alignment with Material theming. * Implemented proper ripple effects and consistent color usage. * Fixed back navigation behavior to align with Compose conventions. * **Theming Note**: The current Compose-based theme system does not yet fully replicate the color palette used in the legacy (pre-Compose) implementation, especially across different services. A `TODO` has been added in code, and a separate task will be created to address this comprehensively.
HatakeKakashri
force-pushed
the
refine_settings_compose_setup
branch
from
d06244f to
92c483b
Compare
HatakeKakashri
force-pushed
the
refine_settings_compose_setup
branch
from
92c483b to
96bb0f6
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR refines the Settings screen setup using Jetpack Compose:
addOnDestinationChangedListener.TODOhas been added in code, and a separate task will be created to address this comprehensively.Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence