fix: filter members-only videos from feeds#12074
fix: filter members-only videos from feeds#12074FineFindus wants to merge 1 commit intoTeamNewPipe:devfrom
Conversation
YouTube has started to mix members-only videos into the normal videos in the Videos tab. This filters them, as they cannot be watched without an account, leading to clutter in the feed. Requires TeamNewPipe/NewPipeExtractor#1280. Closes: TeamNewPipe#12011 Closes: TeamNewPipe#12040
ShareASmile
added
feature request
|
Is this optional? If not, this shouldn't be merged. The video could still be watched in a browser (possibly on another device). |
|
It’s probably better to display some kind of greyed-out version that cannot be clicked as long as we are not able to extract info for the member-only videos, but still list them in the stream (so they can be opened in the browser). Since the upstream change to the extractor is not in yet, I’d close this for now, but thanks for the contribution! |
|
Why not just adding a checkbox in the "Show/Hide streams" menu? We have already a checkbox there for "Upcoming", so it would make sense to add another one for "Members-only" (enabled by default) |
|
I'm strongly against adding preferences, so if that's the preferred solution, I won't continue to work on it. |
|
I agree with you on not adding preferences, but I think a checkbox in the Show/Hide Streams menu is more easily discoverable |
|
#12883 is the issue linked to this. I believe a feed show/hide filter option named "Paywalled" would be great. |
|
It took me forever to find that menu, because I always assumed that settings like that would appear in. well. settings. The eye icon doesn't really tell me anything, and the top right corner of the screen is not a place I usually look. |
|
Seems like the PR in the extractor has already been merged (TeamNewPipe/NewPipeExtractor#1280). Could this be reopened? I agree with @Stypox that there should be an option on the "Show the following streams" menu. |
|
My attempt at a similar fix/feature: #13371 |
8 participants
What is it?
Description of the changes in your PR
YouTube has started to mix members-only videos into the normal videos in the Videos tab. This filters them, as they cannot be watched without an account, leading to clutter in the feed.
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Closes: #12011
Closes: #12040
Relies on the following changes
TeamNewPipe/NewPipeExtractor#1280.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence