Only start playing single item in history screen

[codyit]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Holding an item in history and clicking "Start playing in the background" would now only add the current item in the play queue, instead of the full history which is usually massive.

Before/After Screenshots/Screen Record

N/A

Fixes the following issue(s)

• Fixes Enqueuing/playing a video from history should not queue the whole playlist #5586

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• [ x] I read the contribution guidelines.

[Stypox]

There are people that rely on this behavior (me included) and last time we changed something we got a lot of angry users. During the refactor we will look into redesigning the long-press menu to allow for all of these different options to co-exist (starting without enqueueing everything and starting a playlist from a specific item), but we can't just change one thing without thinking about the whole picture. Sorry about it, and thank you for your contribution anyway.

[Stypox]

Oh wait, you are just doing the change for the history fragment. Then I think the change makes sense.

[Stypox]

Thank you!

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[originalflava]

This was a feature lol.. downgrading to 0.27.2

[qvalentin]

This really should be configurable. Having the history as a playlist is definitely a usecase.
Should I open a new issue for this?

[Profpatsch]

I agree that the fix here is the right thing, there should probably be a separate button to play the whole history in reverse order.

[goyalyashpal]

During the refactor we will look into redesigning the long-press menu to allow for all of these different options to co-exist (starting without enqueueing everything and starting a playlist from a specific item), ...

- @ Stypox at #11696 (comment)

yeah, there should be similar set of options available for most all such items: play single, play, enqueue, enqueue next, enqueue all, etc...

[ShareASmile]

there should be similar set of options available for most all such items: play single, play, enqueue, enqueue next, enqueue all, etc...

Would you like to give your feedback in #12032 ..

[codyit]

Haven't checked github for a while..

One common way to deal with collections is to have a selection mode then a button to quickly select all, this way you won't have to duplicate all the buttons. IMO that would make it nicer and have everyone happy.

I'm happy enough with what we have now or future so I won't be cutting or giving feedback on other issues, although semantically, I still strongly think long pressing an item in a list should always be for actions on the item itself only , as in that creates the least confusion for the most people, which I thought is widely accepted instead of a blue gold dress situation here.

[ShareASmile]

This really should be configurable. Having the history as a playlist is definitely a usecase.
Should I open a new issue for this?

@qvalentin please open a new issue regarding it.

Users are commenting here, but discussion should take place in a dedicated issue not here.