Closed
Conversation
TobiGr
added
search
Collaborator
|
The feature mentioned in the linked issue is something that Youtube directly provides. This PR offers a nice workaround, and is good to have anyway as well, but I don't think it should be considered as having 'fixed' that issue. |
Contributor
Author
|
You are right that should not count as a fix, taking it out of the PR. Not sure how easy it is to implement, might take a shot at it if i find time. |
Contributor
|
Hi @Thompson3142, I’ll close this for now, since we are in the middle of a UI rewrite and don’t accept any new features at the moment. Feel free to reopen it in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
The user can now perform an exact search by quoting the search string. Also works in combination with other filters (Video, Channel, etc.). Does NOT work with youtube music filters at the moment.
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence