Migrate “History and Cache” to Jetpack Compose by braiso-22 · Pull Request #11494 · TeamNewPipe/NewPipe

braiso-22 · 2024-09-01T17:26:51Z

What is it?

Bugfix (user facing)
Feature (user facing)
Codebase improvement (dev facing)
Meta improvement to the project (dev facing)

Description of the changes in your PR

Added daggerHilt DI
Changed the History and cache setting screen to use compose

Before/After Screenshots/Screen Record

Before:
After:

Fixes the following issue(s)

Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

I read the contribution guidelines.

braiso-22 · 2024-09-02T19:05:06Z

@snaik20 can you review this PR?

Isira-Seneviratne

This looks pretty decent, thank you! In particular, the addition of Hilt will be useful.

That being said, I've suggested some improvements.

Profpatsch · 2024-11-20T15:42:59Z

I rebased on current refactor & squashed, but I can’t get it to work. The hilt library is throwing weird injection errors:

/home/philip/kot/android/NewPipe/app/build/generated/hilt/component_sources/debug/org/schabi/newpipe/App_HiltComponents.java:144: error: [Dagger/DuplicateBindings] android.content.SharedPreferences is bound multiple times:
  public abstract static class SingletonC implements FragmentGetContextFix.FragmentGetContextFixEntryPoint,
                         ^
          @Provides @Singleton android.content.SharedPreferences org.schabi.newpipe.AppModule.providesSharedPreference(@dagger.hilt.android.qualifiers.ApplicationContext android.content.Context)
          @Provides @Singleton android.content.SharedPreferences org.schabi.newpipe.dependency_injection.AppModule.provideSharedPreferences(@dagger.hilt.android.qualifiers.ApplicationContext android.content.Context)
      android.content.SharedPreferences is injected at
          org.schabi.newpipe.settings.viewmodel.SettingsViewModel(…, preferenceManager)
      org.schabi.newpipe.settings.viewmodel.SettingsViewModel is injected at
          org.schabi.newpipe.settings.viewmodel.SettingsViewModel_HiltModules.BindsModule.binds(vm)
      @dagger.hilt.android.internal.lifecycle.HiltViewModelMap java.util.Map<java.lang.Class<?>,javax.inject.Provider<androidx.lifecycle.ViewModel>> is requested at
          dagger.hilt.android.internal.lifecycle.HiltViewModelFactory.ViewModelFactoriesEntryPoint.getHiltViewModelMap() [org.schabi.newpipe.App_HiltComponents.SingletonC → org.schabi.newpipe.App_HiltComponents.ActivityRetainedC → org.schabi.newpipe.App_HiltComponents.ViewModelC]
  It is also requested at:
      org.schabi.newpipe.settings.dependency_injection.SettingsModule.provideGetBooleanPreference(sharedPreferences, …)
      org.schabi.newpipe.settings.dependency_injection.SettingsModule.provideGetStringPreference(sharedPreferences, …)
      org.schabi.newpipe.settings.dependency_injection.SettingsModule.provideUpdateBooleanPreference(sharedPreferences, …)
      org.schabi.newpipe.settings.dependency_injection.SettingsModule.provideUpdateStringPreference(sharedPreferences, …)

Profpatsch · 2024-11-20T15:43:24Z

Something I noticed: the old implementation seems to be still around, don’t we want to remove it?

Stypox · 2025-10-01T01:06:56Z

Hey @braiso-22, do you have time to address the reviews and complete this PR? Thanks in advance :-)

braiso-22 · 2025-10-03T10:51:36Z

Hey @braiso-22, do you have time to address the reviews and complete this PR? Thanks in advance :-)

Sorry for leaving this PR unattended for so long! Life has been a bit crazy lately and I completely forgot about it. I'll get back to it soon

Stypox · 2025-10-03T16:20:53Z

Totally understandable, thanks!

# Conflicts: # app/build.gradle # app/src/main/java/org/schabi/newpipe/ui/theme/Color.kt

braiso-22 · 2025-10-04T19:03:18Z

I rebased on current refactor & squashed, but I can’t get it to work. The hilt library is throwing weird injection errors:

/home/philip/kot/android/NewPipe/app/build/generated/hilt/component_sources/debug/org/schabi/newpipe/App_HiltComponents.java:144: error: [Dagger/DuplicateBindings] android.content.SharedPreferences is bound multiple times:
  public abstract static class SingletonC implements FragmentGetContextFix.FragmentGetContextFixEntryPoint,
                         ^
          @Provides @Singleton android.content.SharedPreferences org.schabi.newpipe.AppModule.providesSharedPreference(@dagger.hilt.android.qualifiers.ApplicationContext android.content.Context)
          @Provides @Singleton android.content.SharedPreferences org.schabi.newpipe.dependency_injection.AppModule.provideSharedPreferences(@dagger.hilt.android.qualifiers.ApplicationContext android.content.Context)
      android.content.SharedPreferences is injected at
          org.schabi.newpipe.settings.viewmodel.SettingsViewModel(…, preferenceManager)
      org.schabi.newpipe.settings.viewmodel.SettingsViewModel is injected at
          org.schabi.newpipe.settings.viewmodel.SettingsViewModel_HiltModules.BindsModule.binds(vm)
      @dagger.hilt.android.internal.lifecycle.HiltViewModelMap java.util.Map<java.lang.Class<?>,javax.inject.Provider<androidx.lifecycle.ViewModel>> is requested at
          dagger.hilt.android.internal.lifecycle.HiltViewModelFactory.ViewModelFactoriesEntryPoint.getHiltViewModelMap() [org.schabi.newpipe.App_HiltComponents.SingletonC → org.schabi.newpipe.App_HiltComponents.ActivityRetainedC → org.schabi.newpipe.App_HiltComponents.ViewModelC]
  It is also requested at:
      org.schabi.newpipe.settings.dependency_injection.SettingsModule.provideGetBooleanPreference(sharedPreferences, …)
      org.schabi.newpipe.settings.dependency_injection.SettingsModule.provideGetStringPreference(sharedPreferences, …)
      org.schabi.newpipe.settings.dependency_injection.SettingsModule.provideUpdateBooleanPreference(sharedPreferences, …)
      org.schabi.newpipe.settings.dependency_injection.SettingsModule.provideUpdateStringPreference(sharedPreferences, …)

fixed in the latest commit

braiso-22 · 2025-10-04T19:12:17Z

Something I noticed: the old implementation seems to be still around, don’t we want to remove it?

Do you mean the xml view? I don't know how do we proceed in this case @Isira-Seneviratne what do i do?

braiso-22 · 2025-10-11T17:22:58Z

Hi @Stypox and @Isira-Seneviratne, I think this PR is ready for another review. I’ve addressed some of the comments, and for the ones that seemed out of scope, I’ve added explanations in my replies. Could you please take another look?

braiso-22 · 2025-10-11T21:35:07Z

The pipeline started failing on the ktLint Gradle task in a class I didn’t modify. I’ve merged my branch with the refactor branch again and fixed the two errors reported by the pipeline. You can approve it again.

github-actions Bot added the size/giant PRs with more than 750 changed lines label Sep 1, 2024

TobiGr added the GUI Issue is related to the graphical user interface label Sep 2, 2024

Isira-Seneviratne requested changes Sep 2, 2024

View reviewed changes

braiso-22 mentioned this pull request Sep 20, 2024

History cache compose #11493

Closed

5 tasks

ShareASmile added the rewrite Issues and PRs related to rewrite label Oct 5, 2024

Profpatsch changed the title ~~History cache compose~~ Migrate “History and Cache” to Jetbrains Compose Nov 19, 2024

AudricV changed the title ~~Migrate “History and Cache” to Jetbrains Compose~~ Migrate “History and Cache” to Jetpack Compose Nov 20, 2024

brais-f added 2 commits November 20, 2024 16:38

fixed inversed colors of surface for light theme

2eb85bd

Added the new compose screen with its components and events

c3aa4e7

Profpatsch force-pushed the history_cache_compose branch from 89576ad to c3aa4e7 Compare November 20, 2024 15:41

ShareASmile added the history Anything to do with previously watched stuff label Jan 23, 2025

Stypox added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Oct 1, 2025

github-actions Bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Oct 3, 2025

brais-f added 4 commits October 4, 2025 19:37

Merge branch 'refactor' into history_cache_compose

d01cdb6

# Conflicts: # app/build.gradle # app/src/main/java/org/schabi/newpipe/ui/theme/Color.kt

fix merge with refactor branch

15e6161

change code to more compose friendly as @Isira-Seneviratne said

2fe20b9

use content from compose fragment library as @Isira-Seneviratne said

7f65f1a

braiso-22 requested a review from Isira-Seneviratne October 4, 2025 19:07

brais-f added 2 commits October 11, 2025 19:26

Delete old implementation

2211961

Merge branch 'refactor' into history_cache_compose

69fa98b

Stypox self-assigned this Oct 16, 2025

Uh oh!

Conversation

braiso-22 commented Sep 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is it?

Description of the changes in your PR

Before/After Screenshots/Screen Record

Fixes the following issue(s)

APK testing

Due diligence

Uh oh!

braiso-22 commented Sep 2, 2024

Uh oh!

Isira-Seneviratne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Profpatsch commented Nov 20, 2024

Uh oh!

Profpatsch commented Nov 20, 2024

Uh oh!

Stypox commented Oct 1, 2025

Uh oh!

braiso-22 commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Stypox commented Oct 3, 2025

Uh oh!

braiso-22 commented Oct 4, 2025

Uh oh!

braiso-22 commented Oct 4, 2025

Uh oh!

braiso-22 commented Oct 11, 2025

Uh oh!

braiso-22 commented Oct 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

braiso-22 commented Sep 1, 2024 •

edited

Loading

braiso-22 commented Oct 3, 2025 •

edited

Loading