Skip to content

Commit 813a4f5

Browse files
committed
Add Back content description to toolbar back buttons
1 parent e225326 commit 813a4f5

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

app/src/main/java/org/schabi/newpipe/ui/Toolbar.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ fun TextAction(text: String, modifier: Modifier = Modifier) {
3737
@Composable
3838
fun NavigationIcon() {
3939
Icon(
40-
imageVector = Icons.AutoMirrored.Filled.ArrowBack, contentDescription = "Back",
41-
modifier = Modifier.padding(horizontal = SizeTokens.SpacingExtraSmall)
40+
imageVector = Icons.AutoMirrored.Filled.ArrowBack,
41+
contentDescription = stringResource(R.string.back),
42+
modifier = Modifier.padding(horizontal = SizeTokens.SpacingExtraSmall),
4243
)
4344
}
4445

app/src/main/java/org/schabi/newpipe/ui/components/common/ScaffoldWithToolbar.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ import androidx.compose.material3.Text
1414
import androidx.compose.material3.TopAppBar
1515
import androidx.compose.material3.TopAppBarDefaults
1616
import androidx.compose.runtime.Composable
17+
import androidx.compose.ui.res.stringResource
1718
import androidx.compose.ui.tooling.preview.Preview
19+
import org.schabi.newpipe.R
1820

1921
@OptIn(ExperimentalMaterial3Api::class)
2022
@Composable
@@ -40,7 +42,7 @@ fun ScaffoldWithToolbar(
4042
IconButton(onClick = onBackClick) {
4143
Icon(
4244
imageVector = Icons.AutoMirrored.Filled.ArrowBack,
43-
contentDescription = null
45+
contentDescription = stringResource(R.string.back),
4446
)
4547
}
4648
},

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -908,4 +908,5 @@
908908
<string name="long_press_menu_hidden_actions">Hidden actions:</string>
909909
<string name="long_press_menu_hidden_actions_description">Drag the header or the actions to this section to hide them</string>
910910
<string name="header">Header</string>
911+
<string name="back">Back</string>
911912
</resources>

0 commit comments

Comments
 (0)