Implement LongPressMenuEditor UI (still not persisted)

Author: Stypox

app/src/main/java/org/schabi/newpipe/player/PlayerService.kt

@@ -148,8 +148,8 @@ class PlayerService : MediaBrowserServiceCompat() {
             // a (dummy) foreground notification, otherwise we'd incur in
             // "Context.startForegroundService() did not then call Service.startForeground()". Then
             // we stop the service again.
-            Log.d(TAG, "onStartCommand() got a useless intent, closing the service");
-            NotificationUtil.startForegroundWithDummyNotification(this);
+            Log.d(TAG, "onStartCommand() got a useless intent, closing the service")
+            NotificationUtil.startForegroundWithDummyNotification(this)
             return START_NOT_STICKY
         }
 

app/src/main/java/org/schabi/newpipe/ui/DetectDragModifier.kt

@@ -0,0 +1,50 @@
+package org.schabi.newpipe.ui
+
+import androidx.compose.foundation.gestures.awaitEachGesture
+import androidx.compose.foundation.gestures.awaitFirstDown
+import androidx.compose.ui.Modifier
+import androidx.compose.ui.geometry.Offset
+import androidx.compose.ui.input.pointer.pointerInput
+import androidx.compose.ui.unit.IntOffset
+
+/**
+ * Detects a drag gesture **without** trying to filter out any misclicks. This is useful in menus
+ * where items are dragged around, where the usual misclick guardrails would cause unexpected lags
+ * or strange behaviors when dragging stuff around quickly. For other use cases, use
+ * [androidx.compose.foundation.gestures.detectDragGestures] or
+ * [androidx.compose.foundation.gestures.detectDragGesturesAfterLongPress].
+ *
+ * @param beginDragGesture called when the user first touches the screen (down event) with the
+ * pointer position, should return `true` if the receiver wants to handle this gesture, `false`
+ * otherwise.
+ * @param handleDragGestureChange called with the current pointer position, every time the user
+ * moves the finger after [beginDragGesture] has returned `true`.
+ * @param endDragGesture called when the drag gesture finishes after [beginDragGesture] has returned
+ * `true`.
+ */
+fun Modifier.detectDragGestures(
+    beginDragGesture: (IntOffset) -> Boolean,
+    handleDragGestureChange: (IntOffset) -> Unit,
+    endDragGesture: () -> Unit
+): Modifier {
+    return this.pointerInput(Unit) {
+        awaitEachGesture {
+            val down = awaitFirstDown()
+            val pointerId = down.id
+            if (!beginDragGesture(down.position.toIntOffset())) {
+                return@awaitEachGesture
+            }
+            while (true) {
+                val change = awaitPointerEvent().changes.find { it.id == pointerId }
+                if (change == null || !change.pressed) {
+                    break
+                }
+                handleDragGestureChange(change.position.toIntOffset())
+                change.consume()
+            }
+            endDragGesture()
+        }
+    }
+}
+
+private fun Offset.toIntOffset() = IntOffset(this.x.toInt(), this.y.toInt())

app/src/main/java/org/schabi/newpipe/ui/components/menu/LongPressAction.kt

@@ -60,10 +60,10 @@ data class LongPressAction(
         Enqueue(R.string.enqueue, Icons.Default.AddToQueue),
         EnqueueNext(R.string.enqueue_next_stream, Icons.Default.QueuePlayNext),
         Background(R.string.controls_background_title, Icons.Default.Headset),
-        BackgroundFromHere(R.string.background_from_here, Icons.Default.BackgroundFromHere),
         Popup(R.string.controls_popup_title, Icons.Default.PictureInPicture),
-        PopupFromHere(R.string.popup_from_here, Icons.Default.PopupFromHere),
         Play(R.string.play, Icons.Default.PlayArrow),
+        BackgroundFromHere(R.string.background_from_here, Icons.Default.BackgroundFromHere),
+        PopupFromHere(R.string.popup_from_here, Icons.Default.PopupFromHere),
         PlayFromHere(R.string.play_from_here, Icons.Default.PlayFromHere),
         PlayWithKodi(R.string.play_with_kodi_title, Icons.Default.Cast),
         Download(R.string.download, Icons.Default.Download),
@@ -86,6 +86,16 @@ data class LongPressAction(
             enabled: (isPlayerRunning: Boolean) -> Boolean = { true },
             action: (context: Context) -> Unit,
         ) = LongPressAction(this, action, enabled)
+
+        companion object {
+            // ShowChannelDetails is not enabled by default, since navigating to channel details can
+            // also be done by clicking on the uploader name in the long press menu header
+            val DefaultEnabledActions: Array<Type> = arrayOf(
+                Enqueue, EnqueueNext, Background, Popup, BackgroundFromHere, Download,
+                AddToPlaylist, Share, OpenInBrowser, MarkAsWatched, Delete,
+                Rename, SetAsPlaylistThumbnail, UnsetPlaylistThumbnail, Unsubscribe
+            )
+        }
     }
 
     companion object {