Skip to content

Demo controls - #436

Open
VictorChen1-1 wants to merge 5 commits into
mainfrom
demo-controls
Open

VictorChen1-1 wants to merge 5 commits into
mainfrom
demo-controls

Conversation

@VictorChen1-1

@VictorChen1-1 VictorChen1-1 commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Why are we doing this?

so we can use the robot during demos now that it doesnt have any competitions left
Asana task URL:

Whats changing?

added demo controller config, silenced hoodtozero, routed motor readings from canivore to rio, stop annoying logs

Questions/notes for reviewers

How this was tested

  • tested on robot
  • tested in simulator
  • unit tests added

Video/screenshots (from simulator or live robot)


PR feedback legend

Symbol Meaning
⭐ ⭐ ⭐ must be addressed
⭐ ⭐ should be addressed
⭐ something to consider, a good idea

@VictorChen1-1
VictorChen1-1 requested review from a team and a balanced review from Copilot November 14, 2026 23:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@VictorChen1-1

Copy link
Copy Markdown
Contributor Author

will review more next week before merge


@Override
public void execute() {
XXboxController gamepad = oi.getActiveDriveGamepad();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ how are we limiting the drive to safe speeds when demoing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was assuming we could use elastic. I will also try to limit speed in the next commit. (maybe just for the demo controller? Will give it a try)

.whileTrue(intakeDeployExtendCommand);
operatorInterface.demoGamepad.getifAvailable(XXboxController.XboxButton.RightBumper)
.whileTrue(intakeDeployRetractCommand);
operatorInterface.demoGamepad.getifAvailable(XXboxController.XboxButton.A)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐ so people will have to hold down A and B to shoot? that seems uncomfortable? Do we need separate prepare to shoot and fire when ready buttons?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah.. that's fair. I believe we already have an existing command that does both, or am I mistaken?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have a one button, it's probably for camera based ranging.

Just doing two things in parallel though is easy with the .alongWith() chaining.

In general though I'd encourage you to take a step back and think about explaining the scheme to a random stranger every 2m. What would be really intuitive and easy to use in terms of what button does what?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think minimalist would be a good idea for the demo gamepad. It could be very few commands, but the things im unsure of are the intake deploy retract and collector eject. Are they even worth it to keep in a demo bot? I think we could live with drive, steer, deploy, collect, shoot.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly the thinking you should be doing. Maybe something is needed in unusual circumstances to unjam things, but those could maybe be relegated to the d-pad or something for emergencies?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the d-pad idea. One of the concerns I had when building the controls was honestly that people would fidget with the controller. I've seen nervous drivers/operators fidget with parts of the controllers before and not even realize it, and that's why I was hesitant to try the bottom half of the controller 😅

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be a chord, like you have to hold back and then the d-pad buttons work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants