Repository navigation
Electrical report: multi-robot export, readiness, and web snapshots - #432
Open
tblank1024 wants to merge 31 commits into
Open
tblank1024 wants to merge 31 commits into
tblank1024 wants to merge 31 commits into
Conversation
…ysis and Electrical Report. Added Main.java files for both Electrical Analysis and Electrical Report. Updated build.gradle to include new tasks for running the Electrical Analysis and Electrical Report.
…t2026 into ElectricalChecks
…es that are relevant to electrical group only
Covers split data ownership (Java for code-consumed fields, D1 for electrical-only data), optimistic-concurrency edits, passcode login, GitHub Pages + Cloudflare Workers/D1 hosting, migration steps, and the decisions on all open questions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
Replaces the migration-step list with phases 1-4; phase 1 (local demo) marked done, with notes on where it differs from the original data model. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
`./gradlew electricalReport --args="--json"` writes a machine-readable snapshot for the electrical web tool, using the same discovery as the text report (text output unchanged). Rename Pigeon2()/CANdle() to getPigeon2()/getCandle() so checkstyle passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
Conflicts: contract files take main's versions (main already has the #139 squash of ElectricalChecks plus the GeneralContract refactor and lowercase pigeon2()/candle()); electrical/report/Main.java keeps this branch's version (main's #139 copy plus the --json export). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
main renamed the DIO devices (ClimbHomeDIO -> ClimberSensor), so the name-suffix rule missed them. Treat non-CAN DeviceInfo powered from the RIO as DIO too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
Backend moves from Cloudflare Workers + D1 to Lambda (Function URL) + DynamoDB, deployed with AWS CDK. Adds phase 1b to port the local demo backend, DynamoDB single-table model with transactional versioned writes, cost guard rails, and OIDC-based CI deploys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
… tool Describes how the system works after all phases: data ownership (Programming vs Electrical), data model, concurrency, startup, how changes get back into Java, SystemCore controller profiles, what is not built yet, and how to run it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
- electricalReport takes --contract (Competition, 2025, 2023, Robox), matching the ContractToUse switch in competition.Robot. - New @ReadyWhen(Hardware) on contract getters; devices whose mechanism isn't in the contract's readiness set are left out and listed under "Not on this robot". Drive and CANcoders follow isDriveReady() and areCanCodersReady(). - Snapshot JSON records contractName, robotName, each device's declaring class (definedIn) and the disabled list. - Report-only wiring lists are used only when the robot's own contract class declares them (Robox no longer inherits the 2026 wiring). - plan_Ele_contract.md: multi-robot design (section 3.1) and new not-built items. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
On push to main or ElectricalWeb (contract or exporter changes), export every robot's contract as JSON and publish it to the electrical-snapshots branch, where the electrical web tool reads it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
aschokking
reviewed
Nov 1, 2026
aschokking
left a comment
Contributor
There was a problem hiding this comment.
I think this shows the proof of concept. The PDHPort change should go into SeriouslyCommonLib, probably the ReadyWhen idea as well. The contract and workflow should end up in FRCRobotTemplate so they could get picked up when we create 2027 this year?
… #653) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
… FRCRobotTemplate Adds §10.1 (where each piece lives from 2027, landing order, 2026 unchanged) and the follow-up items in §11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
What moved to SeriouslyCommonLib (#692) and FRCRobotTemplate (#96), the API of the new interface and exporter, how it was checked, landing order, setting up the 2027 repo, and the contract-name clash with 2026 robots on the web. Updates the header, architecture, readiness, startup and run sections to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
…picker Replaces the open contract-name clash with the repo + contract design (§3.1, §4, §8.1, §12.3, §13.6) and adds the wiring-copy follow-up to §11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
…ed-mechanism open item Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
…-web; ignore electrical-report.txt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
…#688 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
…mpetition count Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes to the electrical report tool so the electrical web tool
(https://team488.github.io/electrical-contract-web/) can show every robot the code can run on, and pick up contract changes automatically.
./gradlew electricalReport --args="--contract NAME [--json] [-f FILE]", where NAME is aContractToUsevalue:Competition,2025,2023orRobox. The default isCompetition. The names come from theCONTRACTSmap inelectrical/report/Main.java, which mirrors the switch incompetition.Robot.@ReadyWhen(Hardware.X)annotation goes on theElectricalContractgetters. Devices whose mechanism isn't in the contract's readiness set are left out of the report and listed under "Not on this robot". The drive followsisDriveReady()and the CANcoders followareCanCodersReady(). Robot behavior is unchanged; the annotation is only read by the report tool.--json) for the web tool. It includes each device's declaring class (for exampleGeneralContract), the disabled list, and the contract and robot names.RoboxContractno longer reports the 2026 robot's wiring.Electrical snapshots. On pushes tomainthat touch the contracts or the exporter, it exports every contract and publishes the JSON to theelectrical-snapshotsbranch. The web tool reads it from there, with no secrets and no manual step.plan_Ele_contract.md(the end-state design and how to run it) andplan_electrical_web.md(the design history).Things for reviewers
Contract2026's readiness set leaves outClimberLeft,ClimberRightandClimberSensor. Is the climber really off the robot?Contract2025turns off the drive and every mechanism, so its report has no devices. Is that intended?Contract2023names its steering motors withgetDriveControllerName(), so each corner has two…/Drivemotors. This is the same bug Fix bug with steering motors getting drive names, shadowing the drives #387 fixed for 2026.PDHPortcopy. This branch hassrc/main/java/xbot/common/injection/electrical_contract/PDHPort.java, which extends SeriouslyCommonLib's enum to PDH00–PDH23. It shadows the library class. If the SeriouslyCommonLib versionmainbuilds against already has PDH20–23, the copy can be deleted.After merging
In
Team488/electrical-contract-web, changesnapshotSourceininfra/cdk.jsonfrom.../electrical-snapshots/ElectricalWebto.../electrical-snapshots/main, then runcdk deploy. That way the web followsmain.Testing
./gradlew buildpasses, with checkstyle and the 4 unit tests.Electrical snapshotsAction ran on this branch, and the live web tool imported its output automatically.🤖 Generated with Claude Code
https://claude.ai/code/session_018WRhH1b6vqCkLNMXaAbvnp