Repository navigation
Deprecate in-house path planning and path following - #698
Open
NormalDuck wants to merge 1 commit into
Open
NormalDuck wants to merge 1 commit into
NormalDuck wants to merge 1 commit into
Conversation
Mark the obstacle-avoiding planner, the swerve trajectory and Bezier commands, and tank pure pursuit as @deprecated now that robot projects plan paths with PathPlanner. Nothing is removed yet. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Robot projects now plan and follow paths with PathPlanner, so the library's own path planning and following code is on its way out. TeamXbot2026 still references some of it (
XbotSwervePoint,SwervePointPathPlanning,SwerveSimpleBezierCommand,SwerveSimpleTrajectoryCommand,SwerveSimpleTrajectoryMode,Obstacle), so this PR only deprecates it. Deletion can follow once robot code has moved off these classes.Whats changing?
Each of these types gets
@Deprecatedand a@deprecatedJavadoc note pointing at PathPlanner. There are no behaviour changes and nothing is removed.LowResField,Obstacle,SwervePointPathPlanning,ProvidesWaypointsSwerveSimpleTrajectoryCommand,SwerveSimpleTrajectoryLogic,SwerveSimpleBezierCommand,SwerveSimpleBezierLogic,SwerveSimpleTrajectoryMode,SimpleInterpolator,SimpleTimeInterpolator,XbotSwervePoint,ProvidesInterpolationDataPurePursuitCommand,ConfigurablePurePursuitCommand,PurePursuitTest,PurePursuitTestComponentQuestions/notes for reviewers
RabbitPointandRabbitPointBuilder(only used by pure pursuit andPlanarTestVisualizer),SwervePointKinematics, andSwerveKinematicsCalculator. Say if these should be deprecated too.@Deprecatedrather thanforRemoval = true, because removal warnings also fire inside the deprecated classes that use each other.How this was tested
Annotation-only change;
./gradlew buildpasses locally.🤖 Generated with Claude Code