Repository navigation
Conversation
aschokking
left a comment
There was a problem hiding this comment.
At a high level, I was expecting there to be more logic in here as this is the shared bit. What are things that the arms do all the time that could be in here?
|
|
||
| } | ||
|
|
||
| public abstract Angle getTargetValue(); |
There was a problem hiding this comment.
⭐ ⭐ this probably doesn't have to be abstract does it?
|
|
||
| public abstract Angle getTargetValue(); | ||
|
|
||
| public abstract boolean hasAbsoluteEncoder(); |
There was a problem hiding this comment.
⭐ ⭐ ⭐ this one for sure doesn't need to be abstract, you have an instance variable up above for is there an absolute encoder?
|
|
||
| public abstract boolean hasAbsoluteEncoder(); | ||
|
|
||
| public abstract void setTargetValue(Angle desiredAngle); |
|
|
||
| protected abstract boolean areTwoTargetsEquivalent(Angle target1, Angle target2); | ||
|
|
||
| @Override |
There was a problem hiding this comment.
⭐ ⭐ This periodic override isn't doing anything, the same as removing it. Or is there something that should happen here? Like recording properties?
|
|
||
| public abstract Angle getCurrentValue(); | ||
|
|
||
| public Command getHasAbsoluteEncoder() { |
There was a problem hiding this comment.
❓ what would this command be used for?
| }); | ||
| } | ||
|
|
||
| public Command getCalibrateCommand() { |
There was a problem hiding this comment.
❓ I'm confused about what this one is for as well. Is it about calibrating the current arm position?
| import xbot.common.properties.TunableFactory; | ||
| import xbot.common.subsystems.arm.BaseArmSubsystem; | ||
|
|
||
| public abstract class BaseArmMaintainer extends BaseMaintainerCommand<Angle, Double> { |
There was a problem hiding this comment.
⭐ ⭐ ⭐ this maintainer isn't doing much right now, it's basically the same as not having this class at all and people just extending BaseMaintainer themselves?
Why are we doing this?
Making reusable basics of general subsystems. In this case, we suspect that next year will be a pickup game based off patterns, so we should expect a arm for next year game.
Whats changing?
Adding a base abstract arm subsystem and its maintainer
Questions/notes for reviewers
How this was tested