Skip to content

Adding base arm subsystem - #685

Open
Glowdisk wants to merge 6 commits into
mainfrom
adding-baseArmSubsystem
Open

Glowdisk wants to merge 6 commits into
mainfrom
adding-baseArmSubsystem

Conversation

@Glowdisk

Copy link
Copy Markdown
Contributor

Why are we doing this?

Making reusable basics of general subsystems. In this case, we suspect that next year will be a pickup game based off patterns, so we should expect a arm for next year game.

Whats changing?

Adding a base abstract arm subsystem and its maintainer

Questions/notes for reviewers

How this was tested

  • unit tests added
  • tested on robot

@Glowdisk
Glowdisk requested a review from a team as a code owner October 10, 2026 18:15
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

JUnit results

 73 files  ±0   73 suites  ±0   3s ⏱️ -3s
451 tests ±0  447 ✅ ±0  4 💤 ±0  0 ❌ ±0 
476 runs  ±0  472 ✅ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 07950b9. ± Comparison against base commit 2291a57.

♻️ This comment has been updated with latest results.

@aschokking aschokking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a high level, I was expecting there to be more logic in here as this is the shared bit. What are things that the arms do all the time that could be in here?


}

public abstract Angle getTargetValue();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ this probably doesn't have to be abstract does it?


public abstract Angle getTargetValue();

public abstract boolean hasAbsoluteEncoder();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐ this one for sure doesn't need to be abstract, you have an instance variable up above for is there an absolute encoder?


public abstract boolean hasAbsoluteEncoder();

public abstract void setTargetValue(Angle desiredAngle);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ Same thing here


protected abstract boolean areTwoTargetsEquivalent(Angle target1, Angle target2);

@Override

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ This periodic override isn't doing anything, the same as removing it. Or is there something that should happen here? Like recording properties?


public abstract Angle getCurrentValue();

public Command getHasAbsoluteEncoder() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ what would this command be used for?

});
}

public Command getCalibrateCommand() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ I'm confused about what this one is for as well. Is it about calibrating the current arm position?

import xbot.common.properties.TunableFactory;
import xbot.common.subsystems.arm.BaseArmSubsystem;

public abstract class BaseArmMaintainer extends BaseMaintainerCommand<Angle, Double> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐ this maintainer isn't doing much right now, it's basically the same as not having this class at all and people just extending BaseMaintainer themselves?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants