Skip to content

Show Team 488 name in window title and About dialog - #4

Open
aschokking wants to merge 1 commit into
team-buildfrom
team-branding-title
Open

aschokking wants to merge 1 commit into
team-buildfrom
team-branding-title

Conversation

@aschokking

Copy link
Copy Markdown

Makes team builds recognizable at a glance. Previously only the Start menu entry and the About version string differed from the official app.

Changes (applied at build time in the compile job; no source files edited)

Where Before After
Window title <log> — AdvantageScope <log> — AdvantageScope (Team 488)
About dialog heading AdvantageScope AdvantageScope (Team 488)
About → Distribution FRC 6328 FRC 6328, Team 488 build

The existing sed step for the update-checker repo is folded into the same Node step. It matches exact strings (sed treats the & in &mdash; specially) and fails the build with an annotation if upstream changes any of the target text, so the branding can't silently disappear after a merge.

Stacked on #3. This targets team-build for now; merge #3 first, and GitHub will retarget this PR to main once that branch is deleted.

🤖 Generated with Claude Code

The window title and About heading are hardcoded to "AdvantageScope",
so team builds were indistinguishable from the official app at a glance.
The compile job now rewrites them to "AdvantageScope (Team 488)" and
marks the About "Distribution" line as a Team 488 build.

This replaces the sed step with a small Node step that also handles the
update-checker repo. It matches exact strings (sed treats "&" in
"&mdash;" specially) and fails the build if any target text is missing
upstream.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant