Repository navigation
Show Team 488 name in window title and About dialog - #4
Open
aschokking wants to merge 1 commit into
Open
aschokking wants to merge 1 commit into
aschokking wants to merge 1 commit into
Conversation
The window title and About heading are hardcoded to "AdvantageScope", so team builds were indistinguishable from the official app at a glance. The compile job now rewrites them to "AdvantageScope (Team 488)" and marks the About "Distribution" line as a Team 488 build. This replaces the sed step with a small Node step that also handles the update-checker repo. It matches exact strings (sed treats "&" in "—" specially) and fails the build if any target text is missing upstream. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes team builds recognizable at a glance. Previously only the Start menu entry and the About version string differed from the official app.
Changes (applied at build time in the compile job; no source files edited)
<log> — AdvantageScope<log> — AdvantageScope (Team 488)The existing
sedstep for the update-checker repo is folded into the same Node step. It matches exact strings (sedtreats the&in—specially) and fails the build with an annotation if upstream changes any of the target text, so the branding can't silently disappear after a merge.Stacked on #3. This targets
team-buildfor now; merge #3 first, and GitHub will retarget this PR tomainonce that branch is deleted.🤖 Generated with Claude Code