Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions apps/dokploy/__test__/schedule/schedule-router-boundary.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,50 @@ describe("schedule service/server binding boundary", () => {
);
});

it.each([
{ scheduleType: "dokploy-server" as const },
{ scheduleType: "server" as const, serverId: "server-1" },
])(
"rejects members creating $scheduleType schedules before persistence",
async (hostInput) => {
mocks.findMemberByUserId.mockResolvedValue({ role: "member" });

await expect(
createCaller().create({
...scheduleInput,
...hostInput,
script: "id",
}),
).rejects.toMatchObject({ code: "FORBIDDEN" });

expect(mocks.createSchedule).not.toHaveBeenCalled();
expect(mocks.scheduleJob).not.toHaveBeenCalled();
},
);

it("allows admins to create dokploy-server schedules", async () => {
mocks.createSchedule.mockResolvedValueOnce({
...scheduleInput,
scheduleId: "host-schedule-1",
scheduleType: "dokploy-server",
});

await expect(
createCaller().create({
...scheduleInput,
scheduleType: "dokploy-server",
script: "echo ok",
}),
).resolves.toMatchObject({ scheduleId: "host-schedule-1" });

expect(mocks.createSchedule).toHaveBeenCalledWith(
expect.objectContaining({
scheduleType: "dokploy-server",
organizationId: "org-1",
}),
);
});

it("rejects converting an application schedule into a server schedule", async () => {
await expect(
createCaller().update({
Expand Down
1 change: 1 addition & 0 deletions apps/dokploy/server/api/routers/schedule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ export const scheduleRouter = createTRPCRouter({
}
} else {
await checkPermission(ctx, { schedule: ["create"] });
await assertHostScheduleAccess(ctx, scheduleType, input.serverId);

if (IS_CLOUD && input.scheduleType === "server" && input.serverId) {
await assertScheduledJobLimit(
Expand Down
Loading