Repository navigation
fix(deps): keep one copy of @trpc/server and undici across the workspace - #135
Merged
Merged
Conversation
The daily dependency update (deps/auto-update) failed its tests: every router test that expects a TRPCError got "expected TRPCError to be an instance of TRPCError". apps/dokploy declares `@trpc/server` as `^11.19.0`, packages/server as the exact `11.19.0`. The update moved the range to 11.22.1 and left the exact version alone, so the lockfile kept two copies: packages/server threw TRPCError from 11.19.0 and the router and tests checked against the class from 11.22.1. That also breaks how tRPC maps such errors to HTTP status codes. packages/server now declares `@trpc/server` as `^11.19.0` and `undici` as `^8.12.3`, the ranges apps/dokploy already uses. undici had the same split (`^8.12.3` against `8.12.3`) and would have forked on its next release. The installed versions do not change here; the next daily update moves each package in both places to one version. The exact pins came from upstream, where packages/server pins most packages. CLAUDE.md notes the rule: a package that packages/server and an app both declare takes the same range in both. Checks: bun install --frozen-lockfile; bun run typecheck; the update the daily workflow runs (bun update --recursive, one-day release age) on top of this change leaves one @trpc/server and one undici in bun.lock, and the two test files that failed on deps/auto-update, env/blind-env-router.test.ts and git-provider/git-provider-idor.test.ts, pass on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily dependency update (deps/auto-update) failed its tests: every
router test that expects a TRPCError got "expected TRPCError to be an
instance of TRPCError". apps/dokploy declares
@trpc/serveras^11.19.0, packages/server as the exact11.19.0. The update moved therange to 11.22.1 and left the exact version alone, so the lockfile kept
two copies: packages/server threw TRPCError from 11.19.0 and the router
and tests checked against the class from 11.22.1. That also breaks how
tRPC maps such errors to HTTP status codes.
packages/server now declares
@trpc/serveras^11.19.0andundicias
^8.12.3, the ranges apps/dokploy already uses. undici had the samesplit (
^8.12.3against8.12.3) and would have forked on its nextrelease. The installed versions do not change here; the next daily
update moves each package in both places to one version. The exact
pins came from upstream, where packages/server pins most packages.
CLAUDE.md notes the rule: a package that packages/server and an app
both declare takes the same range in both.
Checks: bun install --frozen-lockfile; bun run typecheck; the update
the daily workflow runs (bun update --recursive, one-day release age)
on top of this change leaves one @trpc/server and one undici in
bun.lock, and the two test files that failed on deps/auto-update,
env/blind-env-router.test.ts and git-provider/git-provider-idor.test.ts,
pass on it.
After the merge, run deps-auto-update again (
gh workflow run deps-auto-update.yml --ref AgentHits-Dev) so #130 is rebuilt on this base.🤖 Generated with Claude Code