Repository navigation
chore(config): migrate Renovate config - #6832
tanguille-cluster[bot] wants to merge 2 commits into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Note No rendered changes. konflate 0.6.6 · rendered |
Not approved: the approval could not be posted Findings
SummaryMigrates Renovate's dashboard footer into the nested dependencyDashboard object
Review context · 6 sources · 0/3 skills · 3/6 commands · 1 overlapping pull request
Reviews (1) · Last reviewed commit: "style: format" · omniroute |
| "github>home-operations/renovate-presets#11.0.0", | ||
| "github>home-operations/renovate-presets//apps/cnpg.json5#11.0.0", | ||
| "github>home-operations/renovate-presets//apps/grafanaDashboards.json5#11.0.0", | ||
| "github>home-operations/renovate-presets//apps/searxng.json5#11.0.0" |
There was a problem hiding this comment.
Restore the rationale comments the migration stripped · maintainability
The migration rewrote the file without comments, which is the documented side effect of the JSON5 rewrite, but the comments were the only record of several constraints a maintainer acts on:
platformAutomerge: false— "main has no required checks, so GitHub native auto-merge would merge before CI finishes; with this off Renovate merges itself only once every check is green (needs Checks: read)". Flipping that flag without the note merges PRs before checks finish.- Why the
github>presets are all tag-pinned, and why thetalosFactorypreset is deliberately omitted (nodes pinghcr.io/tanguille/installer/*, tuppr gates on the siderolabs git tag). - The kernel.org feed check (
curl -s https://www.kernel.org/releases.json | jq '.releases[]|select(.moniker=="stable")') and the warning that a feed shape change yields zero releases so bumps stop silently — that command exists nowhere else in the repository. - The removal condition for the inline-OCI custom manager: "Drop once Renovate's flux manager extracts chart.kind: OCIRepository (renovatebot/renovate#47438)". Without it the workaround becomes permanent.
- Why
timestamp-optional,internalChecksFilter: flexibleand thelogLevelRemapentry are set, and thatcsi.<sidecar>keys miss the flux manager's values heuristic.
Nothing else in the repository restates these; the file's comments are the whole record.
Suggested fix
Re-add the removed comment lines in a follow-up commit on this branch, e.g.:
- Before the
github>presets:// Pin every github> preset to the same tag; an unpinned one tracks main.and, after the last one,// talosFactory preset omitted: nodes pin ghcr.io/tanguille/installer/* and tuppr gates on the siderolabs git tag. - Above
platformAutomerge: false: the two-linemain has no required checks …note. - Above
"linux-kernel": themonikerfilter note plus thecurl … | jqcheck and the "bumps stop SILENTLY" warning. - Above the
"Inline OCI chart sources in HelmReleases"manager'sdescription:// Drop once Renovate's flux manager extracts chart.kind: OCIRepository (renovatebot/renovate#47438). - The remaining rationale comments from the base revision of the file (helm-values ResourceSet note, rebaseWhen, automergeType, timestamp-optional, internalChecksFilter, logLevelRemap, and the per-manager/per-rule notes).
Recover them with git show <base>:.renovaterc.json5` and re-apply as comments above the options they explain.
Prompt for a coding agent
In .renovaterc.json5 at the head of this PR, the Renovate config migration deleted every comment. Restore them with `git show HEAD~1:.renovaterc.json5` as the source, re-adding each `//` comment directly above (or, for the extends/unpinned note, inside) the option it explained, preserving the surrounding JSON5 formatting and 2-space indentation. Do not change any option value. At minimum restore: the `// Pin every github> preset to the same tag; an unpinned one tracks main.` comment before the `github>home-operations/renovate-presets#11.0.0` entry and the `// talosFactory preset omitted: ...` comment after the last preset entry in `extends`; the two-line `// main has no required checks, so GitHub native auto-merge would merge before CI finishes;` / `// with this off Renovate merges itself only once every check is green (needs Checks: read).` comment above `platformAutomerge: false`; the `// Moniker filter survives series bumps; a git mirror would offer -rc tags.` and `// A feed shape change yields zero releases and bumps stop SILENTLY; check: curl -s https://www.kernel.org/releases.json | jq '.releases[]|select(.moniker=="stable")'` comments above `"linux-kernel": {`; and `// Drop once Renovate's flux manager extracts chart.kind: OCIRepository (renovatebot/renovate#47438)` above the `description: "Inline OCI chart sources in HelmReleases"` line. Also restore the notes on `rebaseWhen`, `automergeType`, `minimumReleaseAgeBehaviour`, `internalChecksFilter`, `logLevelRemap`, the `helm-values` ResourceSet override, and the per-manager and per-package-rule rationale comments from the base revision.
The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.
You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.
PLEASE NOTE: JSON5 config file migrated! All comments & trailing commas were removed.
🔕 Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.
❓ Got questions? Does something look wrong to you? Please don't hesitate to request help here.
This PR has been generated by Mend Renovate CLI.