Repository navigation
chore(preact-hotkeys): Support Preact 11 - #172
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 90c898e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established in the reviewed changes. Pre-merge checks |
|
🚀 Changeset Version Preview1 package(s) bumped directly, 0 bumped as dependents. 🟩 Patch bumps
|
@tanstack/alpine-hotkeys
@tanstack/angular-hotkeys
@tanstack/angular-hotkeys-devtools
@tanstack/ember-hotkeys
@tanstack/hotkeys
@tanstack/hotkeys-devtools
@tanstack/lit-hotkeys
@tanstack/octane-hotkeys
@tanstack/preact-hotkeys
@tanstack/preact-hotkeys-devtools
@tanstack/react-hotkeys
@tanstack/react-hotkeys-devtools
@tanstack/solid-hotkeys
@tanstack/solid-hotkeys-devtools
@tanstack/svelte-hotkeys
@tanstack/svelte-hotkeys-devtools
@tanstack/vue-hotkeys
@tanstack/vue-hotkeys-devtools
commit: |
…ck types Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The
preactpeer ranges already allow 11 (>=10.0.0). The adapter source needed no changes.preactdev dependency in the Preact packages and examples goes from^10to^11.0.1, so CI now builds and tests against Preact 11. The peer ranges still allow Preact 10.@tanstack/preact-storegoes to^0.13.5, with a patch changeset. 0.13.4 declaredpreact: ^10.0.0, so npm rejected Preact 11 even though this package's own peer range allows it (Preact 11 compatability table#6616).pnpm-workspace.yamlexempts 0.13.5 from the 24-hour release-age gate because it was published yesterday.useHotkey,useHotkeysanduseHotkeySequenceswrapunmount()inact(). Preact 11 runsuseEffectcleanups after unmount, in the next effect flush, as React 18 does, so the tests checked too early. They pass on both Preact 10 and 11.preact-hotkeys-devtoolsunmount check moves to its ownit.failstest. On Preact 11,@tanstack/devtools-utils@0.7.0never calls the core'sunmount(), which fix(devtools-utils): Unmount Preact panels on Preact 11 devtools#551 fixes. Once a fixed version is installed, the test fails, as a reminder to switch it back toit.🤖 Generated with Claude Code
Summary by CodeRabbit
Compatibility
Tests
Examples