Skip to content

Fix Codex discovery variants and managed validation rejection - #5350

Merged
Trecek merged 15 commits into
developfrom
impl-issue-5343-20261107-153830
Nov 8, 2026
Merged

Trecek merged 15 commits into
developfrom
impl-issue-5343-20261107-153830

Conversation

@Trecek

@Trecek Trecek commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

Codex 0.164.0 emits an additional_tools response item before the skills-bearing developer message. Discovery currently reads content on every item and rejects that output. Expected validation rejection also escapes managed launch bodies and produces a cleanup traceback.

Select consumed message variants before validating their content, retain strict catalog and pre-spawn integrity checks, and add an actionable parse-failure remedy. Carry validation diagnostics to the cook, persistent-launch, and fleet resource owners so they render once before cleanup and exit nonzero after teardown. Genuine cleanup failures continue to propagate.

Includes an actual managed Codex 0.164.0 prompt-input capture with provenance, plus regressions for unrelated variants, malformed consumed content, ambiguous skills blocks, above-pin admission, managed cleanup, and reload rejection. Existing skill guidance is consolidated in the onboarding module to preserve the repository's file and complexity limits.

Validation:

  • Configured test_check passed with conservative filtering: 24,894 passed, 278 skipped, 12 xfailed.
  • pre-commit run --all-files passed.
  • Real installed Codex 0.164.0 managed discovery attestation and its returned pre-spawn check passed.

The CLI minimum remains 0.156.1. No full interactive child launch was performed.

Fixes #5343.

@Trecek
Trecek added this pull request to the merge queue Nov 8, 2026
Merged via the queue into develop with commit 4d869e0 Nov 8, 2026
10 checks passed
@Trecek
Trecek deleted the impl-issue-5343-20261107-153830 branch November 8, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant