Repository navigation
Fix Codex discovery variants and managed validation rejection - #5350
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex 0.164.0 emits an
additional_toolsresponse item before the skills-bearing developer message. Discovery currently readscontenton every item and rejects that output. Expected validation rejection also escapes managed launch bodies and produces a cleanup traceback.Select consumed message variants before validating their content, retain strict catalog and pre-spawn integrity checks, and add an actionable parse-failure remedy. Carry validation diagnostics to the cook, persistent-launch, and fleet resource owners so they render once before cleanup and exit nonzero after teardown. Genuine cleanup failures continue to propagate.
Includes an actual managed Codex 0.164.0 prompt-input capture with provenance, plus regressions for unrelated variants, malformed consumed content, ambiguous skills blocks, above-pin admission, managed cleanup, and reload rejection. Existing skill guidance is consolidated in the onboarding module to preserve the repository's file and complexity limits.
Validation:
test_checkpassed with conservative filtering: 24,894 passed, 278 skipped, 12 xfailed.pre-commit run --all-filespassed.The CLI minimum remains 0.156.1. No full interactive child launch was performed.
Fixes #5343.