Repository navigation
fix(doctor): validate RECORD paths within installation schemes - #5323
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doctor rejected legitimate installer RECORD rows such as
../../../bin/autoskillit, reporting a false integrity error and skipping console-script hash verification. Normalize each RECORD path and bound it to the discovered installation's scheme base, while preserving rejection of parent escapes and similarly named sibling directories.Separate unreadable-file errors from unsupported digest algorithms, add realistic RECORD fixtures and an offline uv wheel-install regression, and remove the fixed clean-install expected failure.
Fixes #5244.
Validation:
test_checkgate (task test-local-gate): 17,463 passed, 269 skipped, 12 expected failures.pre-commit run --all-filespassed.python scripts/check_complexity.py --base developpassed...ban, string-prefix containment, and an overly broad scheme base.Remote clean-install E2E has not yet been run.