Skip to content

fix(doctor): validate RECORD paths within installation schemes - #5323

Merged
Trecek merged 9 commits into
developfrom
impl-doctor-record-scheme-20261025-140913
Oct 25, 2026
Merged

Trecek merged 9 commits into
developfrom
impl-doctor-record-scheme-20261025-140913

Conversation

@Trecek

@Trecek Trecek commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

Doctor rejected legitimate installer RECORD rows such as ../../../bin/autoskillit, reporting a false integrity error and skipping console-script hash verification. Normalize each RECORD path and bound it to the discovered installation's scheme base, while preserving rejection of parent escapes and similarly named sibling directories.

Separate unreadable-file errors from unsupported digest algorithms, add realistic RECORD fixtures and an offline uv wheel-install regression, and remove the fixed clean-install expected failure.

Fixes #5244.

Validation:

  • Configured test_check gate (task test-local-gate): 17,463 passed, 269 skipped, 12 expected failures.
  • pre-commit run --all-files passed.
  • python scripts/check_complexity.py --base develop passed.
  • Read-only host verification confirmed the console script was read with no invalid RECORD path finding.
  • Scratch mutation probes detected the old .. ban, string-prefix containment, and an overly broad scheme base.

Remote clean-install E2E has not yet been run.

@Trecek
Trecek added this pull request to the merge queue Oct 25, 2026
Merged via the queue into develop with commit 1b20175 Oct 25, 2026
10 checks passed
@Trecek
Trecek deleted the impl-doctor-record-scheme-20261025-140913 branch October 25, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant