Skip to content

fix: bind planner dispatch items to declared producers - #5316

Merged
Trecek merged 16 commits into
developfrom
impl-planner-dispatch-provenance-20261024
Oct 25, 2026
Merged

Trecek merged 16 commits into
developfrom
impl-planner-dispatch-provenance-20261024

Conversation

@Trecek

@Trecek Trecek commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Planner fan-out calls substitute {phase_id} or {context_path}, but those inputs compiled as static literals and rejected real item values.

Bind one whole-value item slot to the step's exact dispatch_items producer for both inline and structured inputs. Report malformed declarations during recipe validation, exempt only accepted item slots from unresolved-placeholder findings, and reject an item's own unsubstituted placeholder at runtime. Update the planner admission and receipt regressions to send realistic oracle items and assert the values actually bound.

Refs #5307.

Validation:

  • task test-local-gate: 28,702 passed, 519 skipped, 14 expected failures.
  • pre-commit run --all-files passed.
  • Core stub check passed; recipe compilation and contract regeneration left no generated diff.
  • Scratch recipe checks reject literal producers, duplicate slots, embedded tokens, and unterminated tokens.

Changed source budget lines (limit 750):

  • core/types/recipe/_type_recipe_binding.py: 749
  • recipe/_binding.py: 746
  • recipe/_binding_input.py: 596
  • recipe/contracts/_contracts_types.py: 252
  • recipe/rules/rules_inputs.py: 670

@Trecek
Trecek added this pull request to the merge queue Oct 25, 2026
Merged via the queue into develop with commit e969aa5 Oct 25, 2026
11 checks passed
@Trecek
Trecek deleted the impl-planner-dispatch-provenance-20261024 branch October 25, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant