Repository navigation
fix: bind planner dispatch items to declared producers - #5316
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planner fan-out calls substitute
{phase_id}or{context_path}, but those inputs compiled as static literals and rejected real item values.Bind one whole-value item slot to the step's exact
dispatch_itemsproducer for both inline and structured inputs. Report malformed declarations during recipe validation, exempt only accepted item slots from unresolved-placeholder findings, and reject an item's own unsubstituted placeholder at runtime. Update the planner admission and receipt regressions to send realistic oracle items and assert the values actually bound.Refs #5307.
Validation:
task test-local-gate: 28,702 passed, 519 skipped, 14 expected failures.pre-commit run --all-filespassed.Changed source budget lines (limit 750):
core/types/recipe/_type_recipe_binding.py: 749recipe/_binding.py: 746recipe/_binding_input.py: 596recipe/contracts/_contracts_types.py: 252recipe/rules/rules_inputs.py: 670