Repository navigation
Reject invalid recipe bindings and preserve diagnostics through pruning - #5315
Merged
Merged
Conversation
Trecek
force-pushed
the
impl-binding-failure-validity-20261024-152624
branch
from
October 25, 2026 03:18
ff6db85 to
98c65b0
Compare
Trecek
enabled auto-merge
October 25, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recipe validation could accept bindings that execution snapshots could not install:
bem-wrapper.run_bemomittedcwdand was silently dropped. Validation now rejects every binding failure, preserves declaration diagnostics through pruning, and raises if an uninstallablerun_skillbinding reaches snapshot construction.The change reports missing required tool parameters and incorrect wire shapes, corrects six registry wire types, and repairs affected recipes, dispatch inputs, prompts, and fixtures. It removes the #5310 admission-replay xfail and adds regression coverage plus migration guidance for version
0.10.1293.Validation:
task test-local-gatethrough MCP: 32,219 passed.pre-commit run --all-filespassed; bundled and local eval recipes passed the missing-parameter binding scan.Closes #5310.