Skip to content

fix: use finalized recipe step keys for invocation identity - #5312

Merged
Trecek merged 14 commits into
developfrom
impl-step-identity-20261024-072730
Oct 24, 2026
Merged

Trecek merged 14 commits into
developfrom
impl-step-identity-20261024-072730

Conversation

@Trecek

@Trecek Trecek commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Recipe steps whose declared step_name differed from their YAML key could not pass attested admission. For example, research-implement.decompose_phases declared decompose, so neither name could satisfy lookup and static binding together.

This change makes the finalized YAML key the invoking step's identity:

  • Classify identity parameters in the existing tool registry, with record_pipeline_step.step_name retaining its target-step meaning.
  • Reject divergent effective or declared identities at recipe validation, including steps removed by optional-step pruning.
  • Re-key composed step names and matching identity declarations together without mutating the child recipe or hiding invalid declarations.
  • Align bundled recipe declarations, regenerate compiled JSON and diagram hashes, and update caller instructions and migration guidance.

Regression coverage includes unpruned tracked recipes, role classification, composition, pruning, genuine attested admission, and the instructions delivered to food-truck sessions.

Telemetry and pins

This supersedes #4301 REQ-NAME-001/002. Distinct analyze_pipeline_health_* YAML keys now produce separate token and timing rows; the former family-level aggregation under analyze_pipeline_health is lost. Repeated executions of the same key still share that key. Per-variant model.step_overrides and provider pins now match each variant's own key (#4706).

Validation

  • pre-commit run --all-files: passed.
  • task regen-contracts && task compile-recipes: reproducible with no additional tracked changes.
  • Configured test_check / task test-local-gate: passed (42,872 passed, 592 skipped, 28 expected failures).
  • Measured response maxima increased by exactly 48 bytes. research-implement remains within its unchanged 114,000-character limit at 112,110 serialized characters.

Fixes #5305.

@Trecek
Trecek force-pushed the impl-step-identity-20261024-072730 branch from e14a2f4 to 0036be1 Compare October 24, 2026 18:03
@Trecek
Trecek added this pull request to the merge queue Oct 24, 2026
Merged via the queue into develop with commit adfa846 Oct 24, 2026
11 checks passed
@Trecek
Trecek deleted the impl-step-identity-20261024-072730 branch October 24, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant