Repository navigation
fix: use finalized recipe step keys for invocation identity - #5312
Merged
Merged
Conversation
…licate prose checks
Trecek
force-pushed
the
impl-step-identity-20261024-072730
branch
from
October 24, 2026 18:03
e14a2f4 to
0036be1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recipe steps whose declared
step_namediffered from their YAML key could not pass attested admission. For example,research-implement.decompose_phasesdeclareddecompose, so neither name could satisfy lookup and static binding together.This change makes the finalized YAML key the invoking step's identity:
record_pipeline_step.step_nameretaining its target-step meaning.Regression coverage includes unpruned tracked recipes, role classification, composition, pruning, genuine attested admission, and the instructions delivered to food-truck sessions.
Telemetry and pins
This supersedes #4301 REQ-NAME-001/002. Distinct
analyze_pipeline_health_*YAML keys now produce separate token and timing rows; the former family-level aggregation underanalyze_pipeline_healthis lost. Repeated executions of the same key still share that key. Per-variantmodel.step_overridesand provider pins now match each variant's own key (#4706).Validation
pre-commit run --all-files: passed.task regen-contracts && task compile-recipes: reproducible with no additional tracked changes.test_check/task test-local-gate: passed (42,872 passed, 592 skipped, 28 expected failures).research-implementremains within its unchanged 114,000-character limit at 112,110 serialized characters.Fixes #5305.