Skip to content

Fix MCP kwarg projection and replay builtin admission - #5311

Merged
Trecek merged 12 commits into
developfrom
impl-mcp-kwarg-projection-20261024-072658
Oct 24, 2026
Merged

Trecek merged 12 commits into
developfrom
impl-mcp-kwarg-projection-20261024-072658

Conversation

@Trecek

@Trecek Trecek commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Planner fan-out calls to run_skill were rejected because compilation included dispatch_items in MCP kwargs even though the handler never receives it. Add ToolDef.mcp_kwarg_names as the shared membership view for compilation and runtime admission, preserving validation of recipe-authorable directives. Remove the two #4775 expected-failure bridges and repair the planner test's output directory.

Add an independent caller-payload oracle and replay every delivered, post-prune run_skill step in builtin non-campaign recipes through admission. Pin the ten known rejections to their specific codes and details, require specific raises= types for strict xfail bridges, and register the replay in recipe test filtering.

Validation:

Closes #4775.

Follow-up defects remain tracked in #5305, #5306, #5307, and #5310.

@Trecek
Trecek enabled auto-merge October 24, 2026 16:39
@Trecek
Trecek added this pull request to the merge queue Oct 24, 2026
Merged via the queue into develop with commit a71ffb4 Oct 24, 2026
11 checks passed
@Trecek
Trecek deleted the impl-mcp-kwarg-projection-20261024-072658 branch October 24, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant