Repository navigation
Fix MCP kwarg projection and replay builtin admission - #5311
Merged
Merged
Conversation
Trecek
enabled auto-merge
October 24, 2026 16:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planner fan-out calls to
run_skillwere rejected because compilation includeddispatch_itemsin MCP kwargs even though the handler never receives it. AddToolDef.mcp_kwarg_namesas the shared membership view for compilation and runtime admission, preserving validation of recipe-authorable directives. Remove the two #4775 expected-failure bridges and repair the planner test's output directory.Add an independent caller-payload oracle and replay every delivered, post-prune
run_skillstep in builtin non-campaign recipes through admission. Pin the ten known rejections to their specific codes and details, require specificraises=types for strict xfail bridges, and register the replay in recipe test filtering.Validation:
pre-commit run --all-filespassed for both phases.Closes #4775.
Follow-up defects remain tracked in #5305, #5306, #5307, and #5310.