Repository navigation
Conversation
Add nullable provider: str | None = None field to RecipeStep after the model field in schema.py. Update _PARSE_STEP_HANDLED_FIELDS and _parse_step() constructor call in io.py atomically to keep the import-time field-set guard satisfied. Add tests for provider extraction and absent case. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…onfig Subprocess spawned by the test inherited HOME and loaded ~/.autoskillit/config.yaml, which contained an unrecognized 'features' key that ConfigSchemaError rejected before the server could start. Set HOME to tmp_path/home so the subprocess sees a clean env.
Trecek
commented
May 4, 2026
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved. No issues found across arch, tests, defense, bugs, cohesion, and slop dimensions.
Trecek
commented
May 4, 2026
Trecek
left a comment
Collaborator
Author
There was a problem hiding this comment.
AutoSkillit review passed. No blocking issues found.
Collaborator
Author
|
Closing — wrong base branch (main instead of develop). Will re-run from correct directory. |
Trecek
deleted the
p1-a5-wp1-add-recipestep-provider-field-and-sync-io-py-parsi/1746
branch
May 4, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a nullable
providerfield to theRecipeStepdataclass inschema.pyand update_PARSE_STEP_HANDLED_FIELDSand_parse_step()inio.pyatomically so the import-time field-set guard remains satisfied. This is a data-model extension that mirrors the existingmodelfield pattern.Closes #1746
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260503-233050-209886/.autoskillit/temp/make-plan/add_recipestep_provider_field_plan_2026-05-03_233400.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
Token Efficiency