Skip to content

Add RecipeStep.provider Field and Sync io.py Parsing - #1812

Closed
Trecek wants to merge 2 commits into
mainfrom
p1-a5-wp1-add-recipestep-provider-field-and-sync-io-py-parsi/1746
Closed

Trecek wants to merge 2 commits into
mainfrom
p1-a5-wp1-add-recipestep-provider-field-and-sync-io-py-parsi/1746

Conversation

@Trecek

@Trecek Trecek commented May 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add a nullable provider field to the RecipeStep dataclass in schema.py and update _PARSE_STEP_HANDLED_FIELDS and _parse_step() in io.py atomically so the import-time field-set guard remains satisfied. This is a data-model extension that mirrors the existing model field pattern.

Closes #1746

Implementation Plan

Plan file: /home/talon/projects/autoskillit-runs/impl-20260503-233050-209886/.autoskillit/temp/make-plan/add_recipestep_provider_field_plan_2026-05-03_233400.md

🤖 Generated with Claude Code via AutoSkillit

Token Usage Summary

Step uncached output cache_read cache_write count time
build_execution_map 203 14.9k 523.8k 54.1k 1 5m 36s
plan 162 18.6k 2.1M 133.1k 3 12m 42s
verify 122 19.7k 1.8M 141.8k 3 12m 47s
implement 428 16.3k 1.8M 90.9k 3 5m 17s
fix 536 22.2k 2.4M 135.9k 4 23m 43s
prepare_pr 120 8.2k 359.3k 39.6k 2 2m 22s
compose_pr 51 1.7k 140.0k 14.4k 1 41s
Total 1.6k 101.6k 9.1M 609.8k 1h 3m

Token Efficiency

Step LoC Changed cache_read/LoC cache_write/LoC output/LoC
build_execution_map 0 — — —
plan 0 — — —
verify 0 — — —
implement 187934 9.6 0.5 0.1
fix 5 474353.2 27187.2 4437.4
prepare_pr 0 — — —
compose_pr 0 — — —
Total 187939 48.7 3.2 0.5

Trecek and others added 2 commits May 3, 2026 23:47
Add nullable provider: str | None = None field to RecipeStep after the
model field in schema.py. Update _PARSE_STEP_HANDLED_FIELDS and
_parse_step() constructor call in io.py atomically to keep the import-time
field-set guard satisfied. Add tests for provider extraction and absent case.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…onfig

Subprocess spawned by the test inherited HOME and loaded ~/.autoskillit/config.yaml,
which contained an unrecognized 'features' key that ConfigSchemaError rejected before
the server could start. Set HOME to tmp_path/home so the subprocess sees a clean env.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: approved. No issues found across arch, tests, defense, bugs, cohesion, and slop dimensions.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review passed. No blocking issues found.

@Trecek

Trecek commented May 4, 2026

Copy link
Copy Markdown
Collaborator Author

Closing — wrong base branch (main instead of develop). Will re-run from correct directory.

@Trecek Trecek closed this May 4, 2026
@Trecek
Trecek deleted the p1-a5-wp1-add-recipestep-provider-field-and-sync-io-py-parsi/1746 branch May 4, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1-A5-WP1] Add RecipeStep.provider field and sync io.py parsing

1 participant