Skip to content

fix: Some UI elements only use English strings, even when the translated...#1392

Closed
yosofbadr wants to merge 1 commit into
TagStudioDev:mainfrom
yosofbadr:fix/1316-some-ui-elements-only-use-english-strings-even-when-the-translated-keys
Closed

fix: Some UI elements only use English strings, even when the translated...#1392
yosofbadr wants to merge 1 commit into
TagStudioDev:mainfrom
yosofbadr:fix/1316-some-ui-elements-only-use-english-strings-even-when-the-translated-keys

Conversation

@yosofbadr

Copy link
Copy Markdown

Summary

Fixes #1316 with a focused change.

Changes

  • Updated src/tagstudio/qt/mixed/color_box.py
  • Updated src/tagstudio/qt/mixed/field_containers.py
  • Updated src/tagstudio/qt/mixed/folders_to_tags.py
  • Updated src/tagstudio/qt/mixed/settings_panel.py
  • Updated src/tagstudio/qt/mixed/tag_database.py
  • Updated src/tagstudio/qt/mixed/tag_search.py
  • Updated src/tagstudio/qt/ts_qt.py
  • Updated src/tagstudio/qt/views/main_window.py
  • Updated tests/qt/test_translated_ui_labels.py

Testing

  • Suggested verification commands: python -m pytest

@CyanVoxel

Copy link
Copy Markdown
Member

#1316 already has an open PR aiming to address the issue of missing translation keys: #1290

This PR is also going beyond the scope of applying missing keys to strings, which is misleading from the PR title and description of a "focused change". Also, see my relevant comment from one of your other PRs here on these PR descriptions: #1391 (comment)

@yosofbadr

Copy link
Copy Markdown
Author

Thanks for pointing this out. You're right: I missed that #1290 is already open for #1316, and this PR also went beyond the narrow missing-translation-key scope described in the title/body. I'm closing this to avoid duplicating existing work and adding review noise. I've also paused the automation that opened these rapid-fire PRs and am updating the remaining open PR descriptions to use the project template with accurate testing/platform notes.

@yosofbadr yosofbadr closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Some UI elements only use English strings, even when the translated keys are available

2 participants