fix: render duplicate mirror modal values correctly#1386
Closed
yosofbadr wants to merge 2 commits into
Closed
Conversation
Normalizes path expectations and uses the translation formatter so the regression tests pass across Windows and non-English CI locales.
Author
|
Closing this after a stricter audit. The targeted tests pass locally, but the latest fork CI has not run and a full local pytest run still segfaults in the Qt/PySide stack on my machine. Given that this PR already had CI failures from my test assumptions, I do not want to leave it open without stronger validation. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft / waiting on latest CI.
Fixes #1331 by making the duplicate-entry mirror confirmation and progress text render stable, user-readable values.
The modal now lists duplicate entry paths instead of raw object representations, and the progress label receives the expected
totalvalue for translation formatting. The regression tests were updated to be portable across Windows path separators and translated CI locales.Tasks Completed
uv run --extra pytest python -m pytest tests/qt/test_mirror_entries_modal.py tests/macros/test_dupe_files.py -quv run --extra ruff ruff check src/tagstudio/qt/mixed/mirror_entries_modal.py tests/qt/test_mirror_entries_modal.py