Skip to content

fix: render duplicate mirror modal values correctly#1386

Closed
yosofbadr wants to merge 2 commits into
TagStudioDev:mainfrom
yosofbadr:pi-agent/issue-1331
Closed

fix: render duplicate mirror modal values correctly#1386
yosofbadr wants to merge 2 commits into
TagStudioDev:mainfrom
yosofbadr:pi-agent/issue-1331

Conversation

@yosofbadr

@yosofbadr yosofbadr commented Jun 15, 2026

Copy link
Copy Markdown

Summary

Draft / waiting on latest CI.

Fixes #1331 by making the duplicate-entry mirror confirmation and progress text render stable, user-readable values.

The modal now lists duplicate entry paths instead of raw object representations, and the progress label receives the expected total value for translation formatting. The regression tests were updated to be portable across Windows path separators and translated CI locales.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM - targeted local test/lint
    • Linux x86
    • Linux ARM
      • GitHub Actions for the latest push are awaiting maintainer approval on the fork. Earlier CI failures were due to non-portable test expectations; the latest commit updates those tests.
  • Tested For:
    • Basic functionality - targeted duplicate mirror modal regression tests
    • PyInstaller executable
      • Local: uv run --extra pytest python -m pytest tests/qt/test_mirror_entries_modal.py tests/macros/test_dupe_files.py -q
      • Local: uv run --extra ruff ruff check src/tagstudio/qt/mixed/mirror_entries_modal.py tests/qt/test_mirror_entries_modal.py
      • Missing before marking ready again: latest GitHub Actions run or maintainer acceptance of the local targeted coverage.

@yosofbadr yosofbadr changed the title fix: Attempting to mirror Duplicate entires Instead hangs, and fails to... fix: render duplicate mirror modal values correctly Jun 15, 2026
@CyanVoxel CyanVoxel added TagStudio: Library Relating to the TagStudio library system Status: Review Needed A review of this is needed Type: Fix A fix for a bug, typo, or other issue labels Jun 15, 2026
Normalizes path expectations and uses the translation formatter so the regression tests pass across Windows and non-English CI locales.
@yosofbadr yosofbadr marked this pull request as draft June 16, 2026 16:14
@yosofbadr

Copy link
Copy Markdown
Author

Closing this after a stricter audit. The targeted tests pass locally, but the latest fork CI has not run and a full local pytest run still segfaults in the Qt/PySide stack on my machine. Given that this PR already had CI failures from my test assumptions, I do not want to leave it open without stronger validation.

Sorry for the noise.

@yosofbadr yosofbadr closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Review Needed A review of this is needed TagStudio: Library Relating to the TagStudio library system Type: Fix A fix for a bug, typo, or other issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Attempting to mirror Duplicate entires Instead hangs, and fails to make changes

2 participants