Enable MiniMax models and wire their image/video request format - #36
Open
octo-patch wants to merge 1 commit into
Open
Enable MiniMax models and wire their image/video request format#36octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
Add minimax/MiniMax-M3 and minimax/MiniMax-M2.7 to the allowed model list and format MiniMax multimodal messages using the OpenAI-compatible image_url/video_url schema so MiniMax-M3 can be used for image and video evaluation instead of raising on multimodal input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: The model allowlist omitted MiniMax-M3 and MiniMax-M2.7, and the multimodal request path raised for their image/video inputs, so MiniMax-M3 could not be used for video evaluation.
Changes
src/utils/allowed_models.json: addminimax/MiniMax-M3andminimax/MiniMax-M2.7to the allowed model list so they can be selected as--model/--helper_modeland as evaluation models.mllm_tools/litellm.py: wire the MiniMax image and video request format inLiteLLMWrapper.__call__. MiniMax uses the OpenAI-compatible content schema, so image inputs are sent asimage_urland video inputs asvideo_url(both carrying the encoded data URL). Previously any model other than Gemini/GPT raisedValueErroron multimodal messages, which blocked the video-evaluation path.MiniMax-M3 accepts text, image and video inputs; MiniMax-M2.7 is text-only. Audio and any other unsupported input type still raise a clear
ValueErrorfor MiniMax.Checks
python -m py_compile mllm_tools/litellm.py— passes.jq . src/utils/allowed_models.json— valid JSON with both new entries present.