Revert the truncated-Wigner work (PRs #10 and #11) - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls back both the kept-column D-slice and the analytic/matrix-free rotation, plus the profile_step flag (
git revert -m 1of merges6e36b8fand6f6fd50).Rationale: the analytic path measured 1.8× slower end-to-end on GPU (its backward runs sphericart Hessians on every force call, and the matrix-free application trades one bmm for many small kernels), and the production configuration here uses the fused Triton kernels, which never benefited from the slice either (they already read only the kept D entries). Reverting wholesale keeps the codebase at its pre-#10 simplicity; the work remains in history and in the PR records if a
m_max < l_maxeager configuration ever makes it worth resurrecting — the closed forms and their verification are documented in the reverted commits.Full suite green, ruff clean at the tip.
🤖 Generated with Claude Code