Repository navigation
feat: show finish percents and hits done like the other crafting benches - #33
Conversation
Finishing a woodworking project now shows Recipe, Hits and Total percents in chat, as goldsmithing does. A ruined piece still loses its materials and keeps its title, but now shows how close it came. Only an exact recipe and exact hits read 100. The branding tool's right-click status now lists every tool with the hits done and their total, plus the finish hint, like AdvancedCrafting and GemInfusion. Hit-type needed counts are no longer listed there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Makes Woodworking feedback match the other crafting stations (goldsmithing in GemInfusion, forging in AdvancedCrafting). A player reported that a ruined woodworking piece only said "the materials were lost", with no percentage.
Finishing (left-click with the branding tool)
Recipe: X%,Hits: X%andTotal: X%, like goldsmithing. This happens on both a ruin and a success. A success also showsQuality: <tier>.Branding status (right-click or sneak right-click)
Hits done:with one line per tool (hits done only, never what's needed),Total: N, andLeft-click branding to finish, the same as AdvancedCrafting and GemInfusion.x/neededlines, so it follows the shared rule that the branding status never shows needed counts. The project menu and the per-hit titles still show the hit-type totals.Testing
mvn clean verify: 33 tests, JaCoCo 100% line/branch/instruction coverage met. New tests cover the percent maths (missing, wrong and extra materials, unneeded and overshooting hits, the 99% near-miss cap, empty recipes) and the status/finish messages.Recipe 100% / Hits 100% / Total 100%,Quality: Masterwork, furniture dropped.Recipe 33% / Hits 42% / Total 33%, nothing refunded.Recipe 100% / Hits 42% / Total 42%.station:was pointed at a vanilla crafting table, and the project was selected through a temporary ConditionalEventsplayer_command. Both were restored afterwards. Woodworking logged no errors on Dev.Draft: not for merge or release yet.
🤖 Generated with Claude Code