Repository navigation
feat: add a hidden /tfmc credits listing the staff, helpers and extra credits - #60
Draft
XxFran10xX wants to merge 2 commits into
Draft
XxFran10xX wants to merge 2 commits into
XxFran10xX wants to merge 2 commits into
Conversation
… credits /tfmc credits shows everyone holding a global group on the staff and helper LuckPerms tracks (on duty or not, offline players too, each once under their highest section), then the extra lines from tfmc.yml credits.extra (licence credits such as the OGA-BY music by ISAo). It is deliberately kept out of the Brigadier tree, so it is never suggested, tab-completed or listed; TFMCCore answers the typed command in PlayerCommandPreprocessEvent before the tree sees it. Members come from a LuckPerms storage search, cached for credits.cache-seconds (300). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
the
size:L
XxFran10xX
force-pushed
the
feat/tfmc-credits
branch
from
November 11, 2026 18:39
c29a152 to
04355b8
Compare
…o links - credits-roster.yml remembers everyone the credits listed and the highest section they reached, so staff and helpers who step down stay in (credits.exclude drops someone for good). - Section titles use the TAB rank colours (Staff #f1c40f, Helper #ff00cc) and the header the TAB header colours; names are joined with credits.separator in credits.name format; a footer line closes the list. The music credit has no link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
XxFran10xX
force-pushed
the
feat/tfmc-credits
branch
from
November 11, 2026 18:48
04355b8 to
e85bbc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/tfmc creditslists everyone holding a global group on thestaffandhelper+/helperLuckPerms tracks: on duty or not, offline players too. Each player appears once, under their highest section. After that come the extra lines and a footer.creditsis not in the Brigadier tree, so it is never suggested, tab-completed or listed. TFMCCore answers the typed command inPlayerCommandPreprocessEvent(LOWEST) and cancels it before the tree sees it. This also covers/tfmccore:tfmc credits.credits-roster.ymlremembers everyone the command has listed and the highest section they reached, so staff and helpers who step down stay in.UserManager#searchAllper track group). Groups held only in a server context, expired groups and negated groups don't count. Names use the server's last-seen spelling (with capitals); otherwise LuckPerms' stored name. Results are cached forcredits.cache-seconds(300). If LuckPerms is unavailable, the remembered names and the extra lines still show, and the next use tries again.credits:section intfmc.yml. Section titles use the TAB rank colours and the header uses the TAB header colours. Existing servers keep theirtfmc.yml, so the section has to be added to the live file.Tests
TfmcCommandTest:BukkitTfmcActionsCoverageTest:🤖 Generated with Claude Code