Repository navigation
test: blank campaign templates in the schedule lifecycle test - #245
Merged
Merged
Conversation
CampaignScheduleLifecycleCoverageTest loads no battle templates and only passed while Cache.battleCampaignTemplateField/Siege were still blank. A test that ran the config loader earlier in the same JVM (for example ConfigLoaderBattleTemplateDefaultsTest) leaves them set, and scheduling then failed with "Unknown battle template". Test order differs between CI runners, so main's build and the v4.32.2 release failed on it while the PR build passed. Remember and blank both, as CampaignBattleBoundaryCoverageTest already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@coderabbitai review |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
the
size:XS
Action not completed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #244 merged,
main's build (first attempt) and the v4.32.2 release run (twice) failed on one test, while #244's own PR build passed on the same tree:The test loads no battle templates and only passes while
Cache.battleCampaignTemplateField/Siegeare still blank, as they are in a fresh JVM. A test that ran the config loader earlier in the same JVM leaves them set (field_default, orcustom_fieldfromConfigLoaderBattleTemplateDefaultsTest), andBattleFactory.applyCampaignDefaultthen throws. Test order differs between runners, so this failed on some runs and not on others.Fix (test only)
The test now remembers both fields (restored after each test, like its other
Cachefields) and blanks them, the same asCampaignBattleBoundaryCoverageTestalready does. No plugin code changes.Check
Locally,
-Dsurefire.runOrder=alphabetical -Dtest=ConfigLoaderBattleTemplateDefaultsTest,PluginLifecycleCoverageTest,CampaignScheduleLifecycleCoverageTest:Unknown battle template: custom_field(the CI failure)🤖 Generated with Claude Code