[XxFran10xX]

Summary

CharacterQueueEstate.reconcile (about 90 ms on Main, mostly fsync in QueueFiles.write) ran at enable + 1 h and hourly after. That is the tick most plugins' hourly estate passes share, with the RPCharacters coordinator on the tick before.

• The boot pass still runs on the first tick.
• The hourly passes now start at 1 h 45 min and repeat every hour, the same pattern Archaeo uses with a 15-minute offset.

Nothing players see depends on this timing: RPCharacters' coordinator settles participants itself when an estate is decided and retries hourly. The participant's own pass only backs that up.

Tests

QueueEstateTest checks the boot pass at tick 1, the hourly timer at 126,001 / 72,000, that nothing else is scheduled, and that both tasks run reconcile.

No gameplay change.

Dev test

Dev (TFMCDev01, 11-05): "Recycler enabled.", no estate warnings.

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

• Improvements
  • Estate reconciliation now runs shortly after startup and follows an hourly schedule. This separates the initial check from recurring checks, which begin later and repeat at regular hourly intervals. The updated timing provides distinct startup and ongoing reconciliation runs.

CharacterQueueEstate now schedules a one-tick boot reconciliation and a separate hourly reconciliation. The hourly task starts after the configured delay and repeats every 72,000 ticks. The test checks both schedules and confirms that both tasks call Estates.decided().

Changes: Queue estate reconciliation

Layer / File(s)	Summary
Schedule boot and hourly reconciliation src/main/java/net/tfminecraft/recycler/ownership/CharacterQueueEstate.java, src/test/java/net/tfminecraft/recycler/ownership/QueueEstateTest.java	CharacterQueueEstate.start schedules a one-tick boot task and an hourly task with the configured initial delay and repeat period. The test checks both schedules and verifies that each task calls Estates.decided().

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Suggested reviewers: ryanbarlow97

Merge Risk: Minimal · up to 32452

The scheduling change is ready to merge after normal checks.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: eac3e8e7-0802-4785-b964-2b54a9a59494

Commits

Reviewing files that changed from the base of the PR and between c67bf34 and 32452c8.

Files selected for processing: 2

• src/main/java/net/tfminecraft/recycler/ownership/CharacterQueueEstate.java
• src/test/java/net/tfminecraft/recycler/ownership/QueueEstateTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[XxFran10xX]

@coderabbitai full review

[coderabbitai]

Action performed

Full review finished.