Skip to content

Let categories and skins stay off the website catalog - #46

Draft
XxFran10xX wants to merge 1 commit into
mainfrom
feat/hidden-catalog
Draft

XxFran10xX wants to merge 1 commit into
mainfrom
feat/hidden-catalog

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

What

catalog: false on an ArmourShop category or skin set keeps it out of the catalog sync to the website (PUT /skins/plugin/catalog). The website serves that catalog publicly at /catalog, so today every category and skin id is listed for anyone, including permission-gated ones.

This is for the hidden Bloodsworn class's skins (Magic's blood path). They sit in the public Wild Mage Sets category, each gated by magic.blood.bloodsworn (Magic gives it only to a Bloodsworn character, so other players never see them in the shop), and with catalog: false they never reach the public list either. Hidden content: keep it off the wiki.

Default is unchanged (catalog: true), so existing categories and skins sync as before.

Checks

  • mvn verify: 232 tests, coverage check passes.
  • New tests: a hidden category and a hidden skin are left out of the payload; catalog: false is read on both and survives the category copy.

Pairs with TF-Minecraft/Magic #71 (the permission) and TF-Minecraft/ServerAssets #77 (the Bloodsworn looks). Draft: do not merge yet.

🤖 Generated with Claude Code

catalog: false on a category or a skin set leaves it out of the
catalog sync to the website, whose /catalog is public. Hidden content,
such as a secret class's skins, can then live in a permission-gated
category without being listed for everyone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant