Repository navigation
Let categories and skins stay off the website catalog - #46
Draft
XxFran10xX wants to merge 1 commit into
Draft
XxFran10xX wants to merge 1 commit into
XxFran10xX wants to merge 1 commit into
Conversation
catalog: false on a category or a skin set leaves it out of the catalog sync to the website, whose /catalog is public. Hidden content, such as a secret class's skins, can then live in a permission-gated category without being listed for everyone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
catalog: falseon an ArmourShop category or skin set keeps it out of the catalog sync to the website (PUT /skins/plugin/catalog). The website serves that catalog publicly at/catalog, so today every category and skin id is listed for anyone, including permission-gated ones.This is for the hidden Bloodsworn class's skins (Magic's blood path). They sit in the public Wild Mage Sets category, each gated by
magic.blood.bloodsworn(Magic gives it only to a Bloodsworn character, so other players never see them in the shop), and withcatalog: falsethey never reach the public list either. Hidden content: keep it off the wiki.Default is unchanged (
catalog: true), so existing categories and skins sync as before.Checks
mvn verify: 232 tests, coverage check passes.catalog: falseis read on both and survives the category copy.Pairs with TF-Minecraft/Magic #71 (the permission) and TF-Minecraft/ServerAssets #77 (the Bloodsworn looks). Draft: do not merge yet.
🤖 Generated with Claude Code