Skip to content

Add a crutches base set - #45

Merged
XxFran10xX merged 1 commit into
mainfrom
crutch-base-set
Oct 22, 2026
Merged

XxFran10xX merged 1 commit into
mainfrom
crutch-base-set

Conversation

@XxFran10xX

Copy link
Copy Markdown
Contributor

Adds a crutches base set to the bundled base-sets.yml. Item skins with set: crutches apply to the two forearm crutch MMOItems, props.forearm_crutch and props.forearm_crutch_slim, and to nothing else.

The items come from TF-Minecraft/ServerAssets (new PROPS MMOItems type). The website side is in TF-Minecraft/TFMCWeb. Like #44, live servers need the same entry in their own plugins/ArmourShop/base-sets.yml; the jar default only matters for fresh installs. No Java changes and no release.

Tested on TFMCDev01: the entry was added to Dev's live base-sets.yml with armourshop reload, with no "not an MMOItem" warnings. Bot test ~/crutch-test/test.js passed 12/12. A temporary set: crutches skin in ps_items.yml was refused on a plain stick and a lute ("You carry nothing this design can be applied to.") and applied to both crutches through the normal shop flow.

mvn clean verify passes locally.

🤖 Generated with Claude Code

Item skins with set: crutches apply to the two forearm crutch MMOItems
(props.forearm_crutch and props.forearm_crutch_slim).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ae737764-02b1-402d-bfaf-cd23a4268b72
📥 Commits

Reviewing files that changed from the base of the PR and between 35327dc and 8767049.

📒 Files selected for processing: 1
  • src/main/resources/base-sets.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Added a crutches set featuring two forearm crutch options.

The base sets configuration adds a crutches set containing props.forearm_crutch and props.forearm_crutch_slim.

Changes: Crutches set

Layer / File(s) Summary
Add crutches set
src/main/resources/base-sets.yml
Adds the crutches set and lists the forearm crutch and slim forearm crutch as items.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Suggested reviewers: drefvelin

Merge Risk: ⚪ Minimal · up to 87670

The bundled configuration change is narrowly scoped and ready to merge.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (tests excluded in mixed PRs). label Oct 22, 2026
@XxFran10xX
XxFran10xX marked this pull request as ready for review October 22, 2026 09:24
@XxFran10xX

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@XxFran10xX
XxFran10xX merged commit fd0b5b7 into main Oct 22, 2026
7 checks passed
@XxFran10xX
XxFran10xX deleted the crutch-base-set branch October 22, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant