Skip to content

ci: the workflow comment counts what the run prints - #21

Merged
T-Crypt merged 1 commit into
oh-my-pocketfrom
fix/ci-comment
Oct 13, 2026
Merged

T-Crypt merged 1 commit into
oh-my-pocketfrom
fix/ci-comment

Conversation

@T-Crypt

@T-Crypt T-Crypt commented Oct 13, 2026

Copy link
Copy Markdown
Owner

The post-merge self-review checked the workflow's own comment against the logs and found two claims that do not hold. No code changes.

  • The skip is 139 tests with 501 still running (both legs of run 38434983516 print those counts), not 137 with 503. The 137 was the count before 03: coverage floor and direct tests for the fence #13's tests landed.
  • Of the two runs cited, 38431886203 failed a layout assertion in 8.1 s under the ten second budget the waits had then, so it is not an example of a thirty second budget expiring. That run is dropped; 38433132571 (638 of 640 passed, a wait's thirty second budget expired) and 38429902721 and 38429841208 (same shape, ten second budget) are the ones that fit.
  • The reference to Chrome 154 is gone: no log names a version, and the comment should not claim more than the logs show.

npm run format:check exit 0 (Prettier covers the workflow).

The self-review found two claims that do not match the logs: the skip is 139 tests
with 501 left, not 137 and 503, and one of the two cited runs was a layout assertion
that failed in 8 s under the ten second budget, not a thirty second expiry.
@T-Crypt
T-Crypt merged commit 836a372 into oh-my-pocket Oct 13, 2026
@T-Crypt
T-Crypt deleted the fix/ci-comment branch October 14, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant