Repository navigation
fix: the review's remaining findings, in the gate and in the fence test - #20
Merged
Merged
Conversation
…nd reads the whole report
…r vowels and the Mongolian selectors too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the findings from the review of this flight, both small and neither able to redden a push run on its own.
scripts/check-web.mjs
web/clean having checked nothing. Anerror TSline that is not underweb/now fails the gate.web-clean.txtline with a trailing space or a CRLF ending never matched, so a listed file with an error passed. Each line is trimmed.maxBufferon the findings: past about a megabyte the output truncated,statuswas null, and the step went red without naming a clean file. The bound is 64 MiB and the exit is written throughprocess.exitCodeso the report flushes.Proved against a scratch project:
noinputsandbadoptionexit 0 before and 1 after;trailingandcrlfexit 0 before and 1 after, namingweb/themes.js; a 1.4 MB report is read whole. The realnpm run check:webonweb/is unchanged: exit 0, 3,253 findings, byte-identical output.test/fence.test.ts
Four groups
INVISIBLE_CLASSnames were unpinned, each deletable without a test failing:\\uFE00-\\uFE0F,\\u115F\\u1160,\\u17B4\\u17B5,\\u180B-\\u180F. One representative each, in the same 81-character form the file already uses. Removing any of the four single fragments now fails the file, naming the new representative.src/server/fence.tsis unchanged.Proof
npm test: 640 tests, 640 pass, 0 fail, 0 skipped.node --test test/fence.test.ts: 7 pass.npm run check,npm run lint,npm run format:check: exit 0.