Repository navigation
Clean up release/0.6.0 (Esc in a text field keeps the session selection) - #15
Merged
Merged
Conversation
Owner
Author
|
Review result (one round, verdict: clean).
Two non-blocking notes: an unstaged whitespace-only package-lock.json churn was present in the worktree and was restored before push (not committed), and the implement report paraphrases two test names (counts and assertions match the re-runs). Run folder: ~/handoffs/oh-my-pocket/2026-10-13-pr11-13-cleanup |
# Conflicts: # test/session-row-ui.test.ts
Owner
Author
|
Retargeted from main (a stale mirror of upstream 0.13.0) to oh-my-pocket, the fork's default branch. Merged origin/oh-my-pocket in; no force push. check and lint pass. npm test: 628 pass, 1 fail in test/visible-models-ui.test.ts ("the owner's switches decide which models the model menu offers"), which is flaky on this code (passed then failed on rerun) and outside this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup for the merged release/0.6.0 (PR #13).
Changes:
Proof: the test is red without the guard and green with it. node --test test/session-row-ui.test.ts 13/13. npm run check and npm run lint clean. npm test green (one known Chromium UI test that is load sensitive passed in isolation and at the base commit).
Review: clean on the first pass. The guard matches the plan byte for byte, the test was proven non-vacuous in a scratch worktree at the test-only commit, and the change is confined to the two files.
Run folder: ~/handoffs/oh-my-pocket/2026-10-13-pr11-13-cleanup (review.md, plan.md, pr13-implement.md, review2-pr13.md).