Repository navigation
VFIO (experimental): the harbor shows a card passed through to a VM - #133
Merged
Merged
Conversation
…D; docs and changelog Seen with a real VM holding the card: llama-swap, stopped by the session's --before, read as latched and turned the state pill DEGRADED.
…rough # Conflicts: # CHANGELOG.md
The VFIO row computed its IN VM word but wrote statusText to the cell, so it read DOCKED; only the aria label had the new word. Found rendering the page against the live node with a real VM holding the card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #129, #130 and #131. berthd already reports a card in a VM (
passthroughin the status); the harbor web UI now shows it.card.passthroughandcard.returnedin plain words, and the tide leaves the session as a gap in the data instead of a flat line.Checked against the live node on the reference machine while a Windows VM held the RTX 4090. I ran this branch's harbor on a spare port and rendered it in headless Firefox:
card.passthroughevent the gap is built from.Proof:
TestStatusPassthroughReachesThePage;node --checkon every JS file; full proof green (build, gofmt, vet,go test ./..., Windows build and vet, golangci-lint with 0 issues);mkdocs build --strictpasses.