mplemented issue requirements - #351
Open
amoduenechojo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
enhance(deliveries): integrate local landmark data into workflow cards
Summary
This change enhances the delivery workflow cards to display localized landmark references alongside standard street addresses. The UI now renders landmark information in a visually distinct, wrapped badge-style block so drivers can quickly identify navigation cues in complex street layouts.
What changed
Updated the workflow card layout to support an optional landmark field
Added clear visual emphasis for landmarks to improve readability
Ensured the layout remains responsive on smaller screens without text overflow
Kept the implementation aligned with the existing component → hook → service architecture
Added test coverage for both landmark-present and null-landmark scenarios
Verification
Unit tests for the workflow cards were run successfully
Closes #149
Title:
enhance(escrow): implement volatility slippage warnings for fiat to crypto previews
Summary
This PR adds a clear slippage warning experience for fiat-to-XLM payment previews when the quoted NGN/XLM rate becomes highly volatile. It helps users spot sudden FX movement before confirming a payment and blocks confirmation until they explicitly acknowledge critical volatility.
What changed
Added a warning state for slippage above the 2% threshold
Added a stronger critical warning for slippage above the 5% threshold
Required explicit checkbox acknowledgment before proceeding when slippage is critical
Kept the implementation aligned with the component → hook → service architecture
Wired the warning logic to the live FX rate flow from the backend-backed service layer
Verification
Ran: npm test -- --runTestsByPath FiatXlmPreview.test.tsx fiatXlmSlippageService.test.ts --runInBand
Result: 2/2 test suites passed, 30/30 tests passed
Closes #168