test(logistics): extend qr scanner camera permission boundary tests#349
Open
BigManly4 wants to merge 1 commit into
Open
test(logistics): extend qr scanner camera permission boundary tests#349BigManly4 wants to merge 1 commit into
BigManly4 wants to merge 1 commit into
Conversation
Extend QrScanner camera-permission coverage beyond the existing NotAllowedError case: assert the distinct "No camera device found" fallback for NotFoundError, a generic "Failed to access camera" fallback for other getUserMedia rejections, and that clicking Retry after a permission denial successfully recovers the camera and clears the fallback alert.
|
@BigManly4 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #329
Summary
The exact target file from this issue, tests/components/logistics/QrScanner.test.tsx,
already existed on main with coverage for the getUserMedia NotAllowedError
denial path (asserting the "Camera Permission Denied" text and alert role)
and the successful camera-init path. This PR extends that same file with
the remaining camera-permission boundary cases the hook (useQrScanner)
already handles but weren't yet under test:
that it is NOT confused with the permission-denied fallback.
"Failed to access camera." fallback.
camera, recovers, and clears the fallback alert.
No inline mock objects are introduced; the API success path continues to
be mocked through qrScannerService using the existing fixture in
tests/mocks/qrScannerMockData.ts, and getUserMedia is mocked via
navigator.mediaDevices per test case.
Test plan