test(wallet): add component-level disconnect and session cleanup tests - #348
Open
BigManly4 wants to merge 1 commit into
Open
test(wallet): add component-level disconnect and session cleanup tests#348BigManly4 wants to merge 1 commit into
BigManly4 wants to merge 1 commit into
Conversation
Add component-level tests for DisconnectButton covering the full Component -> Hook -> Service path: clicking disconnect clears the wallet key from localStorage, redirects to /login, and still performs cleanup when the backend disconnect call fails. Only the network boundary (walletService) and router are mocked; useWallet and sessionService run unmocked so the test exercises real cleanup logic.
|
@BigManly4 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #330
Summary
Adds tests/components/wallet/Disconnect.test.tsx, a component-level
test suite for DisconnectButton that verifies session cleanup on
disconnect.
The existing hook-level tests in hooks/tests/useWallet.test.ts
already covered the disconnect flow at the useWallet level. This PR
adds coverage at the component boundary specified in the issue
(tests/components/wallet/Disconnect.test.tsx), rendering the real
DisconnectButton -> useWallet -> sessionService chain and mocking only
the network boundary (walletService) and next/navigation's router, per
the Component -> Hook -> Service architecture and the no-inline-mock
requirement (mock data reused from hooks/tests/fixtures/walletApiResponses.ts).
What's covered
Test plan