feat(escrow,shared,ui): implement multi-sig escrow payout tests, OS-a…#341
Merged
johdanike merged 1 commit intoJul 26, 2026
Conversation
…ware theme provider, and command palette navigation tests
|
@devchant Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR addresses issues #327, #333, and #328 by implementing multi-signature threshold logic tests for the Escrow Payout UI, creating an OS-aware theme provider to eliminate Flash of Unstyled Content (FOUC), and adding interaction tests for the global Command Palette navigation.
The Problem Being Solved
prefers-color-schemeand local storage overrides to eliminate FOUC on page reloads.Cmd+Kkeyboard shortcut toggles and real-time search filtering against backend API delivery records.Implemented Solution
components/escrow/PayoutUI.test.tsx&__tests__/components/escrow/PayoutUI.test.tsx: Added assertions confirming the submit button has the explicitdisabledattribute when thresholds are incomplete (1/2, 0/2, 2/3), and enables only when thresholds are met (2/2, 3/3).components/shared/ThemeProvider.tsx: CreatedThemeProviderwrappingnext-themesand injectingthemeService.getThemeScript()prior to React hydration for instant theme application without FOUC.__tests__/components/shared/CommandPalette.test.tsx: Implemented keystroke event simulation (Ctrl+K/Cmd+K,Escape) and query filtering tests againstcommandPaletteServicebackend API responses.Files Changed
__tests__/components/escrow/PayoutUI.test.tsx[NEW]components/escrow/__tests__/PayoutUI.test.tsx[MODIFY]components/shared/ThemeProvider.tsx[NEW]components/shared/index.ts[MODIFY]app/providers.tsx[MODIFY]__tests__/components/shared/ThemeProvider.test.tsx[NEW]__tests__/components/shared/CommandPalette.test.tsx[MODIFY]components/ui/__tests__/CommandPalette.test.tsx[MODIFY]Technical Decisions & Layered Architecture
escrowService,themeService,commandPaletteService).Testing Evidence
ThemeProvider.test.tsx: 4 passeduseTheme.test.ts: 4 passedPayoutUI.test.tsx: 13 passedCommandPalette.test.tsx: 19 passedCloses #327
Closes #333
Closes #328