Added solution to issue with query string parameters breaking the acl… - #2
Open
hacorbin wants to merge 1 commit into
Open
Added solution to issue with query string parameters breaking the acl…#2hacorbin wants to merge 1 commit into
hacorbin wants to merge 1 commit into
Conversation
Author
|
In my specific scenario, I use acl.prefix = '/api', and the acl check worked great unless my route looked like this: '/api/users?type=admin' (for example). In that case, the "resource" it matched was "users?type=admin", which obviously wasn't in the acl.yml. By using req.path instead of req.baseUrl, this can be remedied. I tested this code with and without acl.prefix set, and with and without a router middleware for '/api'. All versions were tested with passport-jwt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… check