Add request ID to nginx and docassemble logs - #73
Open
rajeswari1301 wants to merge 1 commit into
Open
Conversation
BryceStevenWilley
force-pushed
the
add-request-id-logging
branch
from
August 7, 2026 19:30
dbfd8d2 to
fb4a7d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives every request its own ID starting at nginx, so the logs it produces can be traced together instead of by timestamp.
I tested confirming the ID shows up correctly for normal page loads and background tasks alike, and that a fake client-sent ID gets overridden by nginx's real one rather than trusted.
I didn't wire the ID directly into background task logs, since Celery skips our whole logging setup there, and session ID plus a user identifier in the log line covers what's actually needed for that case, so that's what this does instead. And left nginx's own access log without the ID for now, I couldn't find a reason that needed it.
Addresses #72